-
Notifications
You must be signed in to change notification settings - Fork 18
Update dim__orgs.sql #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master-databricks
Are you sure you want to change the base?
Update dim__orgs.sql #184
Conversation
fe73583
to
cfbbd12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ AI Overview
This AI-generated summary of your pull request analyzes your code changes and their potential impact on your data. As this feature is still experimental, please review the details carefully.
-
Major Data Modifications: Changes to the calculation of
org_id
,num_users
, and subscription data affect 690 out of 788 rows (87.6%). The arbitrary modification ofnum_users
by addingorg_id % 2
may introduce data accuracy issues. -
Subscription Logic Changes: The new logic automatically sets
sub_plan
to 'Individual' for organizations with 1 or fewer users, affecting 227 subscriptions. Additionally,sub_price
now defaults to 0 instead of null, impacting 290 price values. -
Downstream Impact: The changes affect the
sales__sync
table, reducing its row count from 19 to 11. While other downstream tables (fct__monthly__financials
andfct__yearly__financials
) show no changes, the significant modifications to core organizational data suggest careful testing is needed.
🕵️ Details
Base branch | Pull Request branch |
master-databricks (3f06d55) | databricks-patch-1 (cfbbd12) |
Tables modified: 1 (details)
- Different: 1
demo.default.dim__orgs | ||||||||||||||
Primary keys org_id |
||||||||||||||
master-databricks | databricks-patch-1 | |||||||||||||
DIFFERENCES | ||||||||||||||
Exclusive PKs | 12 | 12 | ||||||||||||
3 column(s) with differing values
|
||||||||||||||
View details → | ||||||||||||||
Unchanged Attributes
|
Downstream tables: 3 (details)
- Different: 1
- Identical: 2
demo.default.sales__sync | ||||||||||||||
Primary keys org_id |
||||||||||||||
master-databricks | databricks-patch-1 | |||||||||||||
DIFFERENCES | ||||||||||||||
Total rows | 19 | ↓ 11 -42.1% | ||||||||||||
Exclusive PKs | 8 | 0 | ||||||||||||
View details → | ||||||||||||||
Unchanged Attributes
|
||||||||||||||
Modified upstream modelsmodel.demo.dim__orgs |
demo.default.fct__monthly__financials | ||||||||||||||||||
Primary keys date_month |
||||||||||||||||||
View details → | ||||||||||||||||||
Unchanged Attributes
|
||||||||||||||||||
Modified upstream modelsmodel.demo.dim__orgs |
demo.default.fct__yearly__financials | ||||||||||||||||||
Primary keys date_year |
||||||||||||||||||
View details → | ||||||||||||||||||
Unchanged Attributes
|
||||||||||||||||||
Modified upstream modelsmodel.demo.dim__orgs |
No description provided.