Improve StatVar naming consistency, batch 2 #1099
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmoscoe
reviewed
Jul 31, 2025
| Node: dcid:Count_MedicalConditionIncident_ConditionAcuteFlaccidParalysis | ||
| name: "Number of incidents of acute flaccid paralysis" | ||
| description: "The number of medical condition incidents identified as Acute flaccid paralysis" |
There was a problem hiding this comment.
I'm not going to review every change here yet. Please first ensure the following:
- "incidents" is pluralized everywhere it followsl "number of".
- "medical condition incidents" or just "incidents" is used consistently
- Lowercase everything except conditions named after a person.
The gender- and race-based variables don't follow the conventions I set out in https://docs.google.com/document/d/10dTqGxbcmY9q7QUc0pLaY_r9PnOcT4BQgcJjqrOTGuc/edit. Please do this first.
kmoscoe
reviewed
Aug 4, 2025
| typeOf: dcid:StatisticalVariable | ||
| populationType: dcid:MedicalConditionIncident | ||
| measuredProperty: dcid:count | ||
| statType: dcid:measuredValue | ||
| medicalCondition: dcid:COVID19 | ||
|
|
||
| Node: dcid:Count_MedicalConditionIncident_ConditionDiarrheaWaterWithBlood | ||
| name: "Number of medical condition incident with diarrhea with blood" |
There was a problem hiding this comment.
Above you don't call it "medical condition" incidents. Pick one and be consistent. Also plural "incidents"
kmoscoe
reviewed
Aug 4, 2025
| typeOf: dcid:StatisticalVariable | ||
| populationType: dcid:MedicalConditionIncident | ||
| measuredProperty: dcid:count | ||
| statType: dcid:measuredValue | ||
| medicalCondition: dcid:COVID19 | ||
|
|
||
| Node: dcid:Count_MedicalConditionIncident_ConditionDiarrheaWaterWithBlood | ||
| name: "Number of medical condition incident with diarrhea with blood" | ||
| description: "The Number of medical condition incidents involving Diarrhea with blood" |
There was a problem hiding this comment.
Lowercase number and diarrhea
kmoscoe
reviewed
Aug 4, 2025
| typeOf: dcid:StatisticalVariable | ||
| populationType: dcid:MedicalConditionIncident | ||
| measuredProperty: dcid:count | ||
| statType: dcid:measuredValue | ||
| medicalCondition: dcid:DiarrheaWaterWithBlood | ||
|
|
||
| Node: dcid:Count_MedicalConditionIncident_ConditionDiarrheaWaterWithoutBlood | ||
| name: "Number of medical condition incident with diarrhea without blood" | ||
| description: "The Number of medical condition incidents involving Diarrhea without blood" |
kmoscoe
reviewed
Aug 4, 2025
| typeOf: dcid:StatisticalVariable | ||
| populationType: dcid:MedicalConditionIncident | ||
| measuredProperty: dcid:count | ||
| statType: dcid:measuredValue | ||
| medicalCondition: dcid:DiarrheaWaterWithoutBlood | ||
|
|
||
| Node: dcid:Count_MedicalConditionIncident_ConditionFemaleNonVesGenitalUlcer | ||
| name: "Number of medical condition incident with female non-vesicular Genital ulcer" | ||
| description: "The Number of medical condition incidents involving female non-vesicular Genital ulcer" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated names and descriptions in the following files.