-
Notifications
You must be signed in to change notification settings - Fork 38
Normalize the configured object names to lowercase #1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ 15/15 passed, 1 skipped, 15s total Running from acceptance #730 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Can you add a TODO mentioning we are assuming objects are case insensitive.
having said that, should we handle this per dialect so that we don't run into database specific case handling issues? |
Yeah, that would be ideal. However, this would need refactoring on a large scale, so it may be suitable for a future PR. What do you think? |
Normalize the configured object names to lowercase.
Fixes #1567