Skip to content

Normalize the configured object names to lowercase #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bishwajit-db
Copy link
Contributor

Normalize the configured object names to lowercase.

Fixes #1567

@bishwajit-db bishwajit-db self-assigned this May 12, 2025
@bishwajit-db bishwajit-db requested a review from a team as a code owner May 12, 2025 11:11
@bishwajit-db bishwajit-db added the bug Something isn't working label May 12, 2025
Copy link

github-actions bot commented May 12, 2025

✅ 15/15 passed, 1 skipped, 15s total

Running from acceptance #730

Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can you add a TODO mentioning we are assuming objects are case insensitive.

@sundarshankar89
Copy link
Collaborator

LGTM, Can you add a TODO mentioning we are assuming objects are case insensitive.

having said that, should we handle this per dialect so that we don't run into database specific case handling issues?

@bishwajit-db
Copy link
Contributor Author

LGTM, Can you add a TODO mentioning we are assuming objects are case insensitive.

having said that, should we handle this per dialect so that we don't run into database specific case handling issues?

Yeah, that would be ideal. However, this would need refactoring on a large scale, so it may be suitable for a future PR. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Reconcile of type schema and source Oracle does not find differences.
2 participants