Skip to content

Add Snowflake Connector Implementation #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

goodwillpunning
Copy link
Contributor

Changes

This PR adds a Snowflake connector to the remorph profiler.

What does this PR do?

This Snowflake connector marks the foundation for executing usage collection and other warehouse-related metrics collection queries during workload profiling.

Relevant implementation details

Snowflake provides its own "flavor" of the SQLAlchemy library, snowflake-sqlalchemy. This commit adds the SQLAlchemy library as a dependency to the project.toml file.

Linked issues

Resolves #1470.

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs remorph ...
  • expanded the DatabaseManager class

Tests

  • manually tested
  • added unit tests
  • added integration tests

Copy link

github-actions bot commented May 5, 2025

✅ 16/16 passed, 1 skipped, 21s total

Running from acceptance #564

Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundarshankar89 sundarshankar89 requested review from a team and gueniai May 5, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Schedule job to run extraction
3 participants