Telemetry circuit breaker #658
Conversation
Signed-off-by: Sai Shree Pradhan <[email protected]>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
This reverts commit a5f46eb. Signed-off-by: Sai Shree Pradhan <[email protected]>
saishreeeee
force-pushed
the
tele-circuit-breaker
branch
from
293aeaa to
1b713bd
Compare
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
|
Just confused on why is there even a need for circuit breaker, isn't just handling a good retry mechanism with proper retry behaviour on |
The retry behaviour is per request, while the circuit breaker works across requests. So if a certain number of requests fail, for a time interval, no request will be sent to the server. |
| @@ -11,7 +11,7 @@ You are welcome to file an issue here for general use cases. You can also contac | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| Python 3.8 or above is required. | |||
| Python 3.9 or above is required. | |||
There was a problem hiding this comment.
@jprakash-db are we ok with python version upgrades?
There was a problem hiding this comment.
This should be ok, given DBT tests pass.
Signed-off-by: Sai Shree Pradhan <[email protected]>
src/databricks/sql/common/http.py
Outdated
| try: | ||
| return self.circuit_breaker.call(self.session.post, url, **kwargs) | ||
| except CircuitBreakerError as e: | ||
| logger.error("Circuit breaker error: %s", e) |
There was a problem hiding this comment.
let's keep all logs pretty much silent for telemetry. use trace instead.
Signed-off-by: Sai Shree Pradhan <[email protected]>
What type of PR is this?
Description
Circuit breaker in telemetry to prevent server-side overloading using the PyBreaker library
How is this tested?
Related Tickets & Documents
PECOBLR-711