SEA: Reduce network calls for synchronous commands #633
+58
−80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
In
execute_command
we first send the execute request to the server, following which, if the request is synchronous, we poll for the request state until it is no longer in the pending state. Following this, we make an additionalGET
request to the server to get the final request information. There are two areas of improvement:wait_timeout
, then we need not poll for completion or make anotherGET
request to the server. We can immediately construct ourResultSet
with the provided response.ResultSet
. We need not make anotherGET
request to the server after we are done polling and can instead utilise the last response provided.How is this tested?
Related Tickets & Documents
N/A