Skip to content

Enhance SEA HTTP Client #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 358 commits into
base: sea-migration
Choose a base branch
from
Draft

Enhance SEA HTTP Client #618

wants to merge 358 commits into from
+462 −147

Conversation

varun-edachali-dbx
Copy link
Collaborator

@varun-edachali-dbx varun-edachali-dbx commented Jun 27, 2025 •
edited
Loading

WIP

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

psf/requests#2519 (comment)

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

@varun-edachali-dbx
remove _get_schema_bytes (for now)
b1acc5b 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
redundant comments
ef2a7ee 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
Merge branch 'sea-migration' into exec-phase-sea
699942d
@varun-edachali-dbx
remove fetch phase methods
af8f74e 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
reduce code repetititon + introduce gaps after multi line pydocs
5540c5c 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove unused imports
efe3881 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
move description extraction to helper func
36ab59b 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
formatting (black)
1d57c99 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
add more unit tests
df6dac2 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
streamline unit tests
ad0e527 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
test getting the list of allowed configurations
ed446a0 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
reduce diff
38e4b5c 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
reduce diff
94879c0 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
house constants in enums for readability and immutability
1809956 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
add note on hybrid disposition
da5260c 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
[squashed from cloudfetch-sea] introduce external links + arrow funct…
6ec265f 
…ionality

Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
reduce responsibility of Queue
b2ad5e6 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
reduce repetition in arrow tablee creation
66d0df6 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
reduce redundant code in CloudFetchQueue
eb7ec80 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
move chunk link progression to separate func
a3a8a4a 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove redundant log
ea79bc8 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
improve logging
5b49405 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove reliance on schema_bytes in SEA
015fb76 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove redundant note on arrow_schema_bytes
0385ffb 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
use more fetch methods
5380c7a 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remove redundant schema_bytes from parent constructor
27b781f 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
only call get_chunk_link with non null chunk index
238dc0a 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
align SeaResultSet structure with ThriftResultSet
b3bb07e 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
remvoe _fill_result_buffer from SeaResultSet
13e6346 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
reduce code repetition
f90b4d4 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx varun-edachali-dbx changed the base branch from ext-links-sea to sea-migration July 16, 2025 09:00
@varun-edachali-dbx
pass error as 4th arg, not 3rd
7143eff 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
add warning for legacy behaviour
e3528a1 
Signed-off-by: varun-edachali-dbx <[email protected]>
@varun-edachali-dbx
simplify error handling (attempt)
112958d 
Signed-off-by: varun-edachali-dbx <[email protected]>
@databricks databricks deleted a comment from github-actions bot Jul 17, 2025
@databricks databricks deleted a comment from github-actions bot Jul 17, 2025
@databricks databricks deleted a comment from github-actions bot Jul 17, 2025
@databricks databricks deleted a comment from github-actions bot Jul 17, 2025
@databricks databricks deleted a comment from github-actions bot Jul 17, 2025
@databricks databricks deleted a comment from github-actions bot Jul 17, 2025
@github-actions GitHub Actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@databricks databricks deleted a comment from github-actions bot Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@varun-edachali-dbx