-
Notifications
You must be signed in to change notification settings - Fork 111
Merge SeaHttpClient
into THttpClient
#603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
varun-edachali-dbx
wants to merge
16
commits into
ext-links-sea
Choose a base branch
from
merge-http-client
base: ext-links-sea
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeaHttpClient
with THttpClient
SeaHttpClient
into THttpClient
2c355ef
to
146187c
Compare
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 86968f3. Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 0034d46. Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 08827ef. Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 3e281eb. Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 6a14a72. Signed-off-by: varun-edachali-dbx <[email protected]>
d4870c5
to
6bf5995
Compare
Signed-off-by: varun-edachali-dbx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Currently, the
SeaDatabricksClient
uses a simpleSeaHttpClient
, which helped us introduce SEA features in isolation without having to worry about the HTTP Client details.To allow the re-use of implemented auth and efficiency features in the
THttpClient
, we aim to re-use it in the SEA client and eliminate the oldSeaHttpClient
.How is this tested?
INLINE
disposition andJSON_ARRAY
format) #594The coverage of the newly introduced methods in
THttpClient
bytest_thrift_http_client.py
is as below:thrift_http_client.py
make_rest_request
- Line 321: Logging truncated response content
thrift_http_client.py
_check_rest_response_for_error
Related Tickets & Documents
https://docs.google.com/document/d/1Y-eXLhNqqhrMVGnOlG8sdFrCxBTN1GdQvuKG4IfHmo0/edit?usp=sharing