Skip to content

Merge SeaHttpClient into THttpClient #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: ext-links-sea
Choose a base branch
from

Conversation

varun-edachali-dbx
Copy link
Collaborator

@varun-edachali-dbx varun-edachali-dbx commented Jun 17, 2025

What type of PR is this?

  • Feature

Description

Currently, the SeaDatabricksClient uses a simple SeaHttpClient, which helped us introduce SEA features in isolation without having to worry about the HTTP Client details.

To allow the re-use of implemented auth and efficiency features in the THttpClient, we aim to re-use it in the SEA client and eliminate the old SeaHttpClient.

How is this tested?

The coverage of the newly introduced methods in THttpClient by test_thrift_http_client.py is as below:

Module Function Line Range Statements Missing Coverage Notes
thrift_http_client.py make_rest_request 228-339 112 1 99% Missing coverage in:
- Line 321: Logging truncated response content
thrift_http_client.py _check_rest_response_for_error 340-374 35 0 100% Fully covered

Related Tickets & Documents

https://docs.google.com/document/d/1Y-eXLhNqqhrMVGnOlG8sdFrCxBTN1GdQvuKG4IfHmo0/edit?usp=sharing

@varun-edachali-dbx varun-edachali-dbx changed the title Merge SeaHttpClient with THttpClient Merge SeaHttpClient into THttpClient Jun 18, 2025
@databricks databricks deleted a comment from github-actions bot Jun 20, 2025
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 86968f3.

Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 0034d46.

Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 08827ef.

Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 3e281eb.

Signed-off-by: varun-edachali-dbx <[email protected]>
This reverts commit 6a14a72.

Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant