Fix AppKit template documentation for LLMs #4291
Merged
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLMs were adding query schemas but not running npm run typegen, causing TypeScript errors like "query key not assignable to type". Made Step 3 explicit: run typegen after any schema change. Co-Authored-By: Claude Opus 4.5 <[email protected]>
keugenek
requested review from
a team,
andrewnester,
anton-107,
denik,
lennartkats-db,
pietern and
shreyas-goenka
as code owners
keugenek
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
keugenek
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
keugenek
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
arsenyinfo
approved these changes
Jan 15, 2026
keugenek
changed the title
Collaborator
|
Commit: 2afcf50
21 interesting tests: 10 KNOWN, 7 RECOVERED, 3 flaky, 1 SKIP
Top 44 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 9072fbc
23 interesting tests: 10 KNOWN, 8 RECOVERED, 4 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
## Changes Update the acceptance test output from #4291.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes critical documentation issues causing build failures in LLM-generated AppKit apps.
Changes:
npm run typegena required explicit step after schema changesapp-kit-ui->appkit-ui, added missingsqlimportuseAnalyticsQueryRoot causes addressed:
npm run typegen-> "not assignable to type" errors<BarChart><Bar .../></BarChart>-> TypeScript errors (charts don't accept children)Test plan
🤖 Generated with Claude Code