-
Notifications
You must be signed in to change notification settings - Fork 125
acc: KillProcess: wait for process to be killed #4210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
denik
merged 3 commits into
databricks:main
from
varundeepsaini:fix-flaky-kill-caller-test
Jan 8, 2026
Merged
acc: KillProcess: wait for process to be killed #4210
denik
merged 3 commits into
databricks:main
from
varundeepsaini:fix-flaky-kill-caller-test
Jan 8, 2026
+50
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
reviewed
Jan 7, 2026
74db36e to
5e1224f
Compare
denik
reviewed
Jan 7, 2026
d3e693f to
907aeb2
Compare
Signed-off-by: Varun Deep Saini <[email protected]>
907aeb2 to
f13e5ee
Compare
denik
approved these changes
Jan 8, 2026
Contributor
denik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @varundeepsaini ! Looks good.
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Collaborator
|
Commit: 4652e2d
28 interesting tests: 23 KNOWN, 3 FAIL, 1 RECOVERED, 1 SKIP
Top 15 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 2f9022d
105 interesting tests: 59 MISS, 23 KNOWN, 19 FAIL, 2 PANIC, 1 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After killing the process, it still returns an HTTP 200 response. There's a race condition: the HTTP response (with empty body {}) may be partially received and written to stdout by the CLI before SIGKILL actually terminates it.