Use ruff formatter in DABs templates (replacing Black) #4196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennartkats-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
lennartkats-db
added a commit
that referenced
this pull request
Jan 5, 2026
denik
approved these changes
Jan 5, 2026
pietern
approved these changes
Jan 6, 2026
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
There is a conflict with main remaining to resolve.
- Replace Black with Ruff for formatting and linting in pyproject.toml - Update VS Code settings to use Ruff extension with format on save - Configure Ruff with line-length 120 (matching repo and Workspace editor), recommended rules, and notebook support - Update README with lint commands - Apply to default-python, lakeflow-pipelines, and pydabs templates 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Ruff settings are already configured in pyproject.toml (line-length = 120), and the VS Code Ruff extension automatically picks up settings from pyproject.toml. There's no need to duplicate them in .vscode/settings.json. This simplifies the template by relying on Ruff defaults with only the line length as an exception. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The README previously instructed users to run `uv run ruff check .` and `uv run ruff format .` manually. This is unnecessary since: - VS Code extension handles formatting automatically on save - The Makefile already has `make fmt` and `make lint` for the project maintainers - Users don't need to manually run linting tools 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The `source.organizeImports` setting was added in the Black->Ruff migration but wasn't present in the original template. Removing it to keep the configuration minimal and match the original behavior where import organization is manual. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Restore "Finally," in README test instruction (was in original) - Restore trailing commas in .vscode/settings.json (was in original) - Keep diff minimal compared to main branch - only change what's necessary 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The serverless-customcatalog test was showing a diff in .vscode/settings.json between the baseline and variant, but both should be identical since they use the same template. Running test-update-templates again fixed the consistency issue.
lennartkats-db
force-pushed
the
template-add-lint
branch
from
6bb15bb to
bc1b347
Compare
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 1dee702
26 interesting tests: 17 KNOWN, 8 RECOVERED, 1 SKIP
Top 40 slowest tests (at least 2 minutes):
|
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: ec58ff2
31 interesting tests: 17 KNOWN, 8 RECOVERED, 3 BUG, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This switches the code formatter to ruff and sets the line length to 120 a described in #3675.
Why
Tests