Add --exclude-from and --include-from flags to sync command #2660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
denik
reviewed
Apr 7, 2025
denik
reviewed
Apr 7, 2025
pietern
reviewed
Apr 14, 2025
There was a problem hiding this comment.
I expect --include-from to be almost identical, could you include it in this PR?
Separately, I would prefer if we not use .databricksignore even in our test files. It implies (to me) there are semantics associated with this file name, even though that's something we explicitly don't want.
anton-107
force-pushed
the
anton-107/sync-excludefrom
branch
from
6ba54a9 to
76acd9b
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…isting / missing) 2) refers to exact directory (existing / missing) 3) contains "**"
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
changed the title
denik
reviewed
Apr 17, 2025
andrewnester
approved these changes
Apr 22, 2025
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Apr 23, 2025
## Release v0.249.0 ### CLI * Added `exclude-from` and `include-from` flags support to sync command ([#2660](#2660)) ### Bundles * Correctly translate paths to local requirements.txt file in environment dependencies ([#2736](#2736)) * Check for running resources with --fail-on-active-runs before any mutative operation during deploy ([#2743](#2743))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Exclude-from flag allows users to exclude file patterns from sync operations by providing a .gitignore -like file containing file patterns that should be excluded from sync
Usage:
$ databricks sync <SRC> <DEST> --exclude-from .my-exclude-file$ databricks sync <SRC> <DEST> --include-from .my-include-fileTests