Track variable usage in telemetry #2593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
Mar 31, 2025
| ] | ||
| ], | ||
| "experimental": { | ||
| "configuration_file_count": 0, |
There was a problem hiding this comment.
configuration_file_count and target_count are incorrectly serialized to 0 right now.
configuration_file_countaddressed in Track number of YAML configuration files in a bundle #2589target_countfix is in progress
shreyas-goenka
requested review from
pietern,
andrewnester,
denik and
anton-107
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Apr 2, 2025
|
On hold, to fix this PR I need to use both the annotation as well as the value itself and see it's complex. |
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Apr 22, 2025
denik
reviewed
Apr 22, 2025
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
approved these changes
Apr 23, 2025
| @@ -319,6 +319,22 @@ func logTelemetry(ctx context.Context, b *bundle.Bundle) { | |||
| bundleUuid = b.Config.Bundle.Uuid | |||
| } | |||
|
|
|||
| variableCount := len(b.Config.Variables) | |||
There was a problem hiding this comment.
followup: this function is already big enough to be moved to a separate file for a better readability
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
Based on feedback in #2593 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This gives us insight into usage patterns of variables by customers. Like how popular are lookup variables or complex variables overall compared to just default variables.
Potential followup: track lookup variable usage per resource type.
Tests
Acceptance tests.