Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI for Python code #2448

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kanterov
Copy link
Collaborator

@kanterov kanterov commented Mar 7, 2025

Changes

Add new CI jobs for testing Python code.

These jobs are separate from Golang code because they are executed against a matrix of Python versions, and OS versions are not relevant. We will get coverage with OS versions using acceptance tests. In addition, we don't need to run these tests unless any of the Python code is modified.

We use uv as a package manager to provision all CI tools:

  • pyright to typecheck
  • ruff to lint and format

experimental/python contains a Makefile with target similar to repository root:

  • make fmt
  • make lint
  • make build

Tests

Using CI


NO_CHANGELOG=true

@kanterov kanterov force-pushed the add-databricks-bundles-py-pt0 branch 4 times, most recently from e8cb780 to a0f2cb1 Compare March 7, 2025 09:48
@kanterov kanterov force-pushed the add-databricks-bundles-py-pt0 branch from a0f2cb1 to 5adbf70 Compare March 7, 2025 09:49
@kanterov kanterov marked this pull request as ready for review March 7, 2025 09:50
Copy link
Contributor

@shreyas-goenka shreyas-goenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments.

jobs:
python_tests:
name: tests
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no OS in the matrix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PR description:

These jobs are separate from Golang code because they are executed against a matrix of Python versions, and OS versions are not relevant. We will get coverage with OS versions using acceptance tests. In addition, we don't need to run these tests unless any of the Python code is modified.

@kanterov kanterov force-pushed the add-databricks-bundles-py-pt0 branch from 984e1fa to 7735995 Compare March 10, 2025 08:51
Copy link

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 2448
  • Commit SHA: 773599582c31fb11fe5069ea17894dbbda5199d6

Checks will be approved automatically on success.

@kanterov kanterov requested a review from denik March 10, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants