-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CI for Python code #2448
base: main
Are you sure you want to change the base?
Setup CI for Python code #2448
Conversation
e8cb780
to
a0f2cb1
Compare
a0f2cb1
to
5adbf70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor comments.
jobs: | ||
python_tests: | ||
name: tests | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why no OS in the matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From PR description:
These jobs are separate from Golang code because they are executed against a matrix of Python versions, and OS versions are not relevant. We will get coverage with OS versions using acceptance tests. In addition, we don't need to run these tests unless any of the Python code is modified.
984e1fa
to
7735995
Compare
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Changes
Add new CI jobs for testing Python code.
These jobs are separate from Golang code because they are executed against a matrix of Python versions, and OS versions are not relevant. We will get coverage with OS versions using acceptance tests. In addition, we don't need to run these tests unless any of the Python code is modified.
We use uv as a package manager to provision all CI tools:
experimental/python contains a Makefile with target similar to repository root:
Tests
Using CI
NO_CHANGELOG=true