Move WorkspaceClient to libs/command
#2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
requested review from
pietern,
andrewnester and
denik
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
WorkspaceClient to libs/command
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
reviewed
Mar 7, 2025
| ) | ||
|
|
||
| func SetWorkspaceClient(ctx context.Context, w *databricks.WorkspaceClient) context.Context { | ||
| if v := ctx.Value(workspaceClientKey); v != nil { |
There was a problem hiding this comment.
I think it might okay to do so, for example, overriding with a different workspace client or smth like this, any thoughts?
There was a problem hiding this comment.
I like having this restriction because ideally every command should only configure a working workspace client once. This keep reasoning about auth simple and would force the upstream code to be designed better.
We can ofcourse remove it if we ever have a usercase where we need to override with a different workspace.
andrewnester
approved these changes
Mar 7, 2025
pietern
reviewed
Mar 10, 2025
| @@ -240,7 +241,7 @@ func new{{.PascalName}}() *cobra.Command { | |||
| cmd.PreRunE = root.Must{{if .Service.IsAccounts}}Account{{else}}Workspace{{end}}Client | |||
There was a problem hiding this comment.
The MustZZZ functions should also move to the new pkg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move the WorkspaceClient reader and setter from the root package to
libs/command.Why
This allows us to read the workspace client set in the context in all CLI packages. This was not possible before because using
root.WorkspaceClientwould often result in an import cycle.This would also allow us to standardise reads of the workspace client to be from the context in bundle commands. Today those are read from the bundle object tree instead.
This is a natural followup to #2440.
Tests
Existing tests and one new unit test.
NO_CHANGELOG=true