Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schema field for pipeline in builtin template #2347

Merged
merged 6 commits into from
Mar 5, 2025

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Feb 12, 2025

Changes

The schema field implies the lifecycle of tables is no longer tied to the lifecycle of the pipeline, as was the case with the target field.

More information about using the "catalog" and "schema" properties can be found here: https://docs.databricks.com/en/delta-live-tables/target-schema.html

Tests

n/a

The presence of this field implies that the pipeline is in direct publishing mode.

This is can be used only with Unity Catalog, so the template only configures it if it detects Unity Catalog.
Copy link
Contributor

@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let me ask the team to double-check this.

Copy link
Contributor

@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional LGTM, minor change requested after checking in with the backend team.

@pietern
Copy link
Contributor Author

pietern commented Feb 24, 2025

Holding off on merge until the rollout is fully complete.

@lennartkats-db
Copy link
Contributor

@pietern 👍 this should be good to merge now, the new backend errors for existing pipelines landed last Thursday

@pietern pietern temporarily deployed to test-trigger-is March 3, 2025 10:28 — with GitHub Actions Inactive
@pietern pietern temporarily deployed to test-trigger-is March 3, 2025 10:52 — with GitHub Actions Inactive
@pietern pietern added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 6ae353d Mar 5, 2025
9 checks passed
@pietern pietern deleted the update-template-schema branch March 5, 2025 14:27
andrewnester added a commit that referenced this pull request Mar 5, 2025
CLI:
 * Upgrade Go SDK to 0.59.0 ([#2425](#2425)).

Bundles:
 * Added a warning when `config` section is used in apps ([#2416](#2416)).
 * Switch to use GET workspaces-files/{name} instead of workspace/export for state files to avoid 10MB limit ([#2423](#2423)).
 * Use schema field for pipeline in builtin template ([#2347](#2347)).
 * Add warning when variable interpolation is used for auth fields ([#2399](#2399)).
 * Add warning when include is used in config files other than databricks.yml ([#2389](#2389)).
 * Add support for schemas in deployment bind/unbind commands ([#2406](#2406)).
 * Do not modify/create .gitignore in bundle root ([#2429](#2429)).
 * Raise an error when there are multiple local libraries with the same basename used  ([#2382](#2382)).
 * Upgrade TF provider to 1.68.0 ([#2426](#2426)).

API Changes:
 * Changed `databricks experiments log-inputs` command with new required argument order.
 * Added `databricks genie get-space` command.
 * Added `databricks providers list-provider-share-assets` command.
 * Changed `databricks shares update-permissions` command return type to become non-empty.

OpenAPI commit e5c870006a536121442cfd2441bdc8a5fb76ae1e (2025-03-03)
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2025
CLI:
* Upgrade Go SDK to 0.59.0
([#2425](#2425)).

Bundles:
* Added a warning when `config` section is used in apps
([#2416](#2416)).
* Switch to use GET workspaces-files/{name} instead of workspace/export
for state files to avoid 10MB limit
([#2423](#2423)).
* Use schema field for pipeline in builtin template
([#2347](#2347)).
* Add warning when variable interpolation is used for auth fields
([#2399](#2399)).
* Add warning when include is used in config files other than
databricks.yml ([#2389](#2389)).
* Add support for schemas in deployment bind/unbind commands
([#2406](#2406)).
* Do not modify/create .gitignore in bundle root
([#2429](#2429)).
* Raise an error when there are multiple local libraries with the same
basename used ([#2382](#2382)).
* Upgrade TF provider to 1.68.0
([#2426](#2426)).

API Changes:
* Changed `databricks experiments log-inputs` command with new required
argument order.
 * Added `databricks genie get-space` command.
 * Added `databricks providers list-provider-share-assets` command.
* Changed `databricks shares update-permissions` command return type to
become non-empty.

OpenAPI commit e5c870006a536121442cfd2441bdc8a5fb76ae1e (2025-03-03)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants