Enable offline install of labs projects #2049

HariGS-DB · 2024-12-27T16:00:16Z

Changes

This PR makes changes to the labs code base to allow for offline installation of labs projects (like UCX). By passing a flag --offline=true, the code will skip checking for project versions and download code from GitHub and instead will look from the local installation folder. This cmd is useful in systems where there is internet restriction, the user should follow a set-up as follows:

install a labs project on a machine which has internet
zip and copy the file to the intended machine and
run databricks labs install --offline=true
it will look for the code in the same install directory and if present load from there.

Closes #1646

related to databrickslabs/ucx#3418

Tests

Added unit test case and tested.

NO_CHANGELOG=true

.vscode/settings.json

cmd/labs/install.go

cmd/labs/github/releases.go

cmd/labs/project/installer.go

alexott

lgtm

.vscode/settings.json

cmd/labs/project/fetcher.go

HariGS-DB · 2025-02-19T23:32:02Z

@pietern Have addressed your comments. Please could you review and send for int tests?

cmd/labs/project/fetcher.go

pietern · 2025-02-24T09:49:08Z

cmd/labs/project/fetcher.go

+			return nil, file_err
+		}
+		fileName := filepath.Join(libDir, "labs.yml")
+		raw, err = os.ReadFile(fileName)


Please document how you expect this to work.

@pietern have addressed your other comments. As this is my first, could you please help where should I update the documentation for cli. Basically the idea is, for system with no access to internet

install a labs project on a machine which has internal

zip and copy the file to the intended machine and run databricks labs install --offline=true

it will look for the code in the same install directory and if present load from there.

Thanks. Please include this as a comment in the test as well as the PR description.

@pietern have updated the PR please check

…tion (databricks#2043) ## Changes Changes the warning about an incomplete / implicit permissions section into a recommendation, and does a minor bit of cleanup. ## Tests New unit test.

## Changes - Instead of collecting requests in memory and writing them at the end of the test, write them right away. Then test authors can do filtering with jq in 'script' or collect individual files per different command. - testserver is now simpler - it just calls a caller-provided function. The logging logic is moved to acceptance_test.go. See https://github.com/databricks/cli/pull/2359/files#r1967591173 ## Tests Existing tests.

…ource reference doc template (databricks#2314) ## Changes - Added some missing descriptions to annotations.yml - Fixed links in the resource reference doc template ## Tests

## Changes Previously, one could not set `LocalOnly=true` in parent directory and then override it with `LocalOnly=false` in child directory. This is because, `false` is considered empty value by mergo. In order to distinguish between 'explicitly set to false' and 'not set', I've changed all simple variables in config to be pointers. Now, one can always override those, because non-nil pointers are not null (with mergo.WithoutDereference option). ## Tests Manually: ``` ~/work/cli/acceptance/bundle/templates/default-python % cat test.toml # add this new file LocalOnly = false ~/work/cli/acceptance/bundle/templates/default-python % CLOUD_ENV=aws go test ../../.. -run ^TestAccept$/^bundle$/^templates$/^default-python$ -v (the test is no longer skipped) ```

…icks#2356) ## Changes Added missing .gitignore files to templates ## Tests There were some incorrect snapshots of gitignore files in acceptance tests, probably generated by testing infra. Updated them to new files --------- Co-authored-by: Lennart Kats (databricks) <[email protected]>

… to 0.58.1 (databricks#2357) Bumps [github.com/databricks/databricks-sdk-go](https://github.com/databricks/databricks-sdk-go) from 0.57.0 to 0.58.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/databricks/databricks-sdk-go/releases">github.com/databricks/databricks-sdk-go's releases</a>.</em></p> <blockquote> <h2>v0.58.1</h2> <h3>Internal Changes</h3> <ul> <li>Do not send ForceSendFields as query parameters.</li> </ul> <h2>v0.58.0</h2> <h2>[Release] Release v0.58.0</h2> <h3>New Features and Improvements</h3> <ul> <li>Enable async refreshes for OAuth tokens (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/1143">#1143</a>).</li> </ul> <h3>Internal Changes</h3> <ul> <li>Add support for asynchronous data plane token refreshes (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/1142">#1142</a>).</li> <li>Introduce new TokenSource interface that takes a <code>context.Context</code> (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/1141">#1141</a>).</li> </ul> <h3>API Changes:</h3> <ul> <li>Added <code>GetMessageQueryResultByAttachment</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI">w.Genie</a> workspace-level service.</li> <li>Added <code>Id</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#App">apps.App</a>.</li> <li>Added <code>LimitConfig</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#UpdateBudgetPolicyRequest">billing.UpdateBudgetPolicyRequest</a>.</li> <li>Added <code>Volumes</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#ClusterLogConf">compute.ClusterLogConf</a>.</li> <li>Removed <code>ReviewState</code>, <code>Reviews</code> and <code>RunnerCollaborators</code> fields for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/cleanrooms#CleanRoomAssetNotebook">cleanrooms.CleanRoomAssetNotebook</a>.</li> </ul> <p>OpenAPI SHA: 99f644e72261ef5ecf8d74db20f4b7a1e09723cc, Date: 2025-02-11</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/databricks/databricks-sdk-go/blob/main/CHANGELOG.md">github.com/databricks/databricks-sdk-go's changelog</a>.</em></p> <blockquote> <h2>[Release] Release v0.58.1</h2> <h3>Internal Changes</h3> <ul> <li>Do not send ForceSendFields as query parameters.</li> </ul> <h2>[Release] Release v0.58.0</h2> <h3>New Features and Improvements</h3> <ul> <li>Enable async refreshes for OAuth tokens (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/1143">#1143</a>).</li> </ul> <h3>Internal Changes</h3> <ul> <li>Add support for asynchronous data plane token refreshes (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/1142">#1142</a>).</li> <li>Introduce new TokenSource interface that takes a <code>context.Context</code> (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/1141">#1141</a>).</li> </ul> <h3>API Changes:</h3> <ul> <li>Added <code>GetMessageQueryResultByAttachment</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#GenieAPI">w.Genie</a> workspace-level service.</li> <li>Added <code>Id</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/apps#App">apps.App</a>.</li> <li>Added <code>LimitConfig</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#UpdateBudgetPolicyRequest">billing.UpdateBudgetPolicyRequest</a>.</li> <li>Added <code>Volumes</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#ClusterLogConf">compute.ClusterLogConf</a>.</li> <li>Added .</li> <li>Removed <code>ReviewState</code>, <code>Reviews</code> and <code>RunnerCollaborators</code> fields for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/cleanrooms#CleanRoomAssetNotebook">cleanrooms.CleanRoomAssetNotebook</a>.</li> </ul> <p>OpenAPI SHA: 99f644e72261ef5ecf8d74db20f4b7a1e09723cc, Date: 2025-02-11</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/databricks/databricks-sdk-go/commit/967d0632b7676ca14b3dae154dcc2f727f4350c6"><code>967d063</code></a> [Release] Release v0.58.1 (<a href="https://redirect.github.com/databricks/databricks-sdk-go/issues/1146">#1146</a>)</li> <li><a href="https://github.com/databricks/databricks-sdk-go/commit/9dc3c56fb0afb65e8597f205db087fb2c6cca21d"><code>9dc3c56</code></a> [Release] Release v0.58.0 (<a href="https://redirect.github.com/databricks/databricks-sdk-go/issues/1144">#1144</a>)</li> <li><a href="https://github.com/databricks/databricks-sdk-go/commit/8307a4d467368f6a4290cba179a334d1f816ebd6"><code>8307a4d</code></a> [Feature] Enable async refreshes for OAuth tokens (<a href="https://redirect.github.com/databricks/databricks-sdk-go/issues/1143">#1143</a>)</li> <li><a href="https://github.com/databricks/databricks-sdk-go/commit/815cace601ed08e11794d9c20e8c42e6af376f4a"><code>815cace</code></a> [Internal] Add support for asynchronous data plane token refreshes (<a href="https://redirect.github.com/databricks/databricks-sdk-go/issues/1142">#1142</a>)</li> <li><a href="https://github.com/databricks/databricks-sdk-go/commit/3aebd68bf334b94e63974963cd967f836b559a48"><code>3aebd68</code></a> [Internal] Introduce new TokenSource interface that takes a <code>context.Context</code>...</li> <li>See full diff in <a href="https://github.com/databricks/databricks-sdk-go/compare/v0.57.0...v0.58.1">compare view</a></li> </ul> </details> <br /> <details> <summary>Most Recent Ignore Conditions Applied to This Pull Request</summary> | Dependency Name | Ignore Conditions | | --- | --- | | github.com/databricks/databricks-sdk-go | [>= 0.28.a, < 0.29] | </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/databricks/databricks-sdk-go&package-manager=go_modules&previous-version=0.57.0&new-version=0.58.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Nester <[email protected]>

## Changes 1. add ".idea" entry to ".gitgnore" ## Tests 1. manually checked that with this change files under .idea/ folder are not staged for commit

## Changes - Get rid of artifacts.DetectPackages which is a thin wrapper around artifacts/whl.DetectPackage - Get rid of parsing name out of setup.py. Do not randomize either, use a static one. ## Tests Existing tests.

…n flag (databricks#2373) ## Changes CLI generation template was using RequiredPathField from incorrect request entity (body field from request and not request itself). Thus for some of the commands required path parameters were not required when --json was specified. ## Tests Regenerated commands work correctly

…tabricks#2374) ## Changes Previously using python wheel tasks in the tasks with compute referering to interactive cluster defied in the same bundle would produce a warning like below ``` GET /api/2.1/clusters/get?cluster_id=${resources.clusters.development_cluster.id} < HTTP/2.0 400 Bad Request < { < "error_code": "INVALID_PARAMETER_VALUE", < "message": "Cluster ${resources.clusters.development_cluster.id} does not exist" < } pid=14465 mutator=seq mutator=initialize mutator=seq mutator=PythonWrapperWarning sdk=true ``` This PR fixes it by making sure that we check spark version for such clusters based on its bundle configuration and don't make API calls ## Tests Added acceptance test

) ## Changes Added PyPi and Maven libraries tests Needed for this PR since we don't currently have any coverage for PyPi or Maven libraries databricks#2382

## Changes This PR: 1. No longer sets the `DATABRICKS_CLI_PARENT_PID` environment variable since it was never required in the first place and was mistakenly merged in the inital PR. 2. Performs minor cleanup based on post merge feedback in databricks#2354. ## Tests N/A

…atabricks#2372) ## Changes 1. Change the **default-python** bundle template to set `data_security_mode` of a cluster to SINGLE_USER 2. Change the **experimental-jobs-as-code** bundle template to set `data_security_mode` of a cluster to SINGLE_USER ## Why Explicitly adding this field saves experienced users from confusion onto what security mode is applied to the cluster ## Tests Changed existing unit and integration tests to pass with this change

…ed (databricks#2335) ## Changes Now when `profile` flag is used we won't pick up host from bundle anymore and use the one provided by -p flag Previous behaviour in the context of bundle ``` databricks current-user me -p profile_name Error: cannot resolve bundle auth configuration: config host mismatch: profile uses host https://non-existing-subdomain.databricks.com, but CLI configured to use https://foo.com ``` New behaviour (make an api call) ``` databricks current-user me -p profile_name { email: "[email protected]" ... } ``` We still load bundle configuration when `-t` flag provide because we want to load host information from the target. Fixes databricks#1358 ## Tests Added acceptance test

…atabricks#2377) ## Changes - Add 'serverless' prompt to default-python template (default is currently set to "no"). - This is a simplified version of databricks#2348 with 'auto' functionality removed. ## Tests - Split default-python into default-python/classic, default-python/serverless, default-python/serverless-customcatalog. - Manually check that "bundle init default-python" with serverless=yes can be deployed and run on dogfood and test env.

## Changes Fix diff.py to apply replacements that have newlines in them. ## Tests Existing tests.

…ks#2386) ## Changes Since at this moment we set default to 'no', interactively it should also default to 'no'. However, it just uses the first option. ## Tests Manually running `cli bundle init default-python`

…2388) ## Tests Manually running 'bundle init default-python' - no question about serverless.

## Changes Instead of LocalOnly with non-composable semantics there are two composable options: - Local - enable test locally - Cloud - enable test on the cloud By default Cloud is switched off except in bundle (but not in bundle/variables and bundle/help). ## Tests Using this in databricks#2383 to have test that runs on cloud but not locally.

## Tests Include full output of default-python/classic so it can be used as a base for diffs in cloud tests databricks#2383

Notable changes: Starting this version CLI does not load bundle auth information when CLI command is executed inside the bundle directory with explicitly provided via `-p` flag profile. For more details see the related GitHub issue databricks#1358 CLI: * Do not load host from bundle for CLI commands when profile flag is used ([databricks#2335](databricks#2335)). * Fixed accessing required path parameters in CLI generation when --json flag ([databricks#2373](databricks#2373)). Bundles: * Provide instructions for testing in the default-python template ([databricks#2355](databricks#2355)). * Remove `run_as` from the built-in templates ([databricks#2044](databricks#2044)). * Change warning about incomplete permissions section into a recommendation ([databricks#2043](databricks#2043)). * Refine `mode: production` diagnostic output ([databricks#2236](databricks#2236)). * Support serverless mode in default-python template (explicit prompt) ([databricks#2377](databricks#2377)). * Set default data_security_mode to "SINGLE_USER" in bundle templates ([databricks#2372](databricks#2372)). * Fixed spark version check for clusters defined in the same bundle ([databricks#2374](databricks#2374)). API Changes: * Added `databricks genie get-message-query-result-by-attachment` command. OpenAPI commit 99f644e72261ef5ecf8d74db20f4b7a1e09723cc (2025-02-11)

…nctions (databricks#2390) ## Changes - Instead of constructing chains of mutators and then executing them, execute them directly. - Remove functionality related to chain-building: Seq, If, Defer, newPhase, logString. - Phases become functions that apply the changes directly rather than construct mutator chains that will be called later. - Add a helper ApplySeq to call multiple mutators, use it where Apply+Seq were used before. This is intended to be a refactoring without functional changes, but there are a few behaviour changes: - Since defer() is used to call unlock instead of bundle.Defer() unlocking will now happen even in case of panics. - In --debug, the phase names are are still logged once before start of the phase but each entry no longer has 'seq' or phase name in it. - The message "Deployment complete!" was printed even if terraform.Apply() mutator had an error. It no longer does that. ## Motivation The use of the chains was necessary when mutators were returning a list of other mutators instead of calling them directly. But that has since been removed, so now the chain machinery have no purpose anymore. Use of direct functions simplifies the logic and makes bugs more apparent and easy to fix. Other improvements that this unlocks: - Simpler stacktraces/debugging (breakpoints). - Use of functions with narrowly scoped API: instead of mutators that receive full bundle config, we can use focused functions that only deal with sections they care about prepareGitSettings(currentGitSection) -> updatedGitSection. This makes the data flow more apparent. - Parallel computations across mutators (within phase): launch goroutines fetching data from APIs at the beggining, process them once they are ready. ## Tests Existing tests.

…#2394) ## Tests Manually, I have a test that fails. Before: ``` === NAME TestAccept server.go:195: ---------------------------------------- No stub found for pattern: GET /api/2.1/clusters/get To stub a response for this request, you can add the following to test.toml: [[Server]] Pattern = "GET /api/2.1/clusters/get" Response.Body = ''' <response body here> ''' Response.StatusCode = <response status-code here> ---------------------------------------- ``` After: ``` server.go:203: No handler for URL: /api/2.1/clusters/get?cluster_id=0717-132531-5opeqon1 Body: [0 bytes] For acceptance tests, add this to test.toml: [[Server]] Pattern = "GET /api/2.1/clusters/get" Response.Body = '<response body here>' # Response.StatusCode = <response code if not 200> ```

## Changes This PR adds a recovery function for panics. This indicates to all users running into a panic that it's a bug and they should report it to Databricks. ## Tests Manually and acceptance test. Before: ``` .venv➜ cli git:(panic-r) ✗ ./cli selftest panic panic: the databricks selftest panic command always panics goroutine 1 [running]: github.com/databricks/cli/cmd/selftest.New.newPanic.func1(0x1400016f208?, {0x1016ca925?, 0x4?, 0x1016ca929?}) /Users/shreyas.goenka/cli2/cli/cmd/selftest/panic.go:9 +0x2c github.com/spf13/cobra.(*Command).execute(0x1400016f208, {0x10279bc40, 0x0, 0x0}) /Users/shreyas.goenka/cli2/cli/vendor/github.com/spf13/cobra/command.go:989 +0x81c github.com/spf13/cobra.(*Command).ExecuteC(0x14000428908) /Users/shreyas.goenka/cli2/cli/vendor/github.com/spf13/cobra/command.go:1117 +0x344 github.com/spf13/cobra.(*Command).ExecuteContextC(...) /Users/shreyas.goenka/cli2/cli/vendor/github.com/spf13/cobra/command.go:1050 github.com/databricks/cli/cmd/root.Execute({0x101d60440?, 0x10279bc40?}, 0x10266dd78?) /Users/shreyas.goenka/cli2/cli/cmd/root/root.go:101 +0x58 main.main() /Users/shreyas.goenka/cli2/cli/main.go:13 +0x44 ``` After: ``` .venv➜ cli git:(panic-r) ./cli selftest panic The Databricks CLI unexpectedly had a fatal error. Please report this issue to Databricks in the form of a GitHub issue at: https://github.com/databricks/cli CLI Version: 0.0.0-dev+aae7ced52d36 Panic Payload: the databricks selftest panic command always panics Stack Trace: goroutine 1 [running]: runtime/debug.Stack() /Users/shreyas.goenka/go/pkg/mod/golang.org/[email protected]/src/runtime/debug/stack.go:26 +0x64 github.com/databricks/cli/cmd/root.Execute.func1() /Users/shreyas.goenka/cli2/cli/cmd/root/root.go:110 +0xa4 panic({0x10368b5e0?, 0x1039d6d70?}) /Users/shreyas.goenka/go/pkg/mod/golang.org/[email protected]/src/runtime/panic.go:785 +0x124 github.com/databricks/cli/cmd/selftest.New.newPanic.func1(0x14000145208?, {0x103356be5?, 0x4?, 0x103356be9?}) /Users/shreyas.goenka/cli2/cli/cmd/selftest/panic.go:9 +0x2c github.com/spf13/cobra.(*Command).execute(0x14000145208, {0x104427c40, 0x0, 0x0}) /Users/shreyas.goenka/cli2/cli/vendor/github.com/spf13/cobra/command.go:989 +0x81c github.com/spf13/cobra.(*Command).ExecuteC(0x14000400c08) /Users/shreyas.goenka/cli2/cli/vendor/github.com/spf13/cobra/command.go:1117 +0x344 github.com/spf13/cobra.(*Command).ExecuteContextC(...) /Users/shreyas.goenka/cli2/cli/vendor/github.com/spf13/cobra/command.go:1050 github.com/databricks/cli/cmd/root.Execute({0x1039ec440?, 0x104427c40?}, 0x14000400c08) /Users/shreyas.goenka/cli2/cli/cmd/root/root.go:128 +0x94 main.main() /Users/shreyas.goenka/cli2/cli/main.go:13 +0x44 ```

…s.yml (databricks#2389) ## Changes Defining an include section in config files other than the main `databricks.yml` file fails silently. With this PR users will get a warning when they try this. ## Tests Acceptance test.

…bricks#2399) ## Changes This PR adds a warning which gives users clear guidance when they try to use variable interpolation for an auth field. ## Tests Modify existing acceptance test.

…basename used (databricks#2382) ## Changes It could happen that there are multiple artifacts defined in the bundle which build and therefore deploy wheel packages with the same name. This leads to conflict between these packages, they will overwrite each other and therefore they should have different names instead Fixes databricks#1674 Previous attempt (databricks#2297 + databricks#2341) led to the breakage, this PR fixes both issues. ## Tests Added acceptance test

… Java 8 (databricks#2385) ## Changes 1. Refactored `TestSparkJarTaskDeployAndRunOnVolumes` and `TestSparkJarTaskDeployAndRunOnWorkspace` to use a table-driven approach for better organization of similar tests 2. Implemented `testutil.HasJDK()` to replace `testutil.RequireJDK` to be able to skip tests 3. Ensured the test suite properly fails if no compatible Java version is found ## Why It can be tricky to have Java 8 installed on modern dev environments (e.g. Mac on Apple M3 chip). The absence of which previously caused the Spark Jar task tests to fail when run locally. This refactoring allows such environments to be able to run "SparkJar" tests using a newer Databricks Runtime. ## Tests 1. Ran `TestSparkJarTaskDeployAndRunOnVolumes` and `TestSparkJarTaskDeployAndRunOnWorkspace` locally on Mac with Java11 installed. 2. Checked that tests against older runtimes are still being run and passing in CI/CD environments

alexott

lgtm from the code perspective - we need to add a doc how to use it.

github-actions · 2025-03-08T22:22:18Z

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

PR number: 2049
Commit SHA: 2b5201f5d0db397da7cbf358d2c53bb4bbf1bd20

Checks will be approved automatically on success.

HariGS-DB added 2 commits December 27, 2024 15:51

commit for offline install

98bdd8d

commit for offlineinstall

c514cca

HariGS-DB temporarily deployed to test-trigger-is December 27, 2024 16:00 — with GitHub Actions Inactive

alexott reviewed Jan 20, 2025

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

cmd/labs/install.go Outdated Show resolved Hide resolved

cmd/labs/github/releases.go Outdated Show resolved Hide resolved

cmd/labs/project/installer.go Show resolved Hide resolved

resolving review comments

41313db

HariGS-DB requested review from pietern, andrewnester, shreyas-goenka and denik as code owners January 27, 2025 17:57

HariGS-DB added 3 commits January 27, 2025 17:58

review comments

870003d

changing the logic for offline install

4ed82de

added check for local dir exists in offline mode

d846c91

alexott approved these changes Jan 28, 2025

View reviewed changes

pietern changed the title ~~Enable offline install of labs projects in environment with no internet access~~ Enable offline install of labs projects Jan 29, 2025

pietern reviewed Jan 29, 2025

View reviewed changes

.vscode/settings.json Outdated Show resolved Hide resolved

cmd/labs/project/fetcher.go Outdated Show resolved Hide resolved

cmd/labs/project/fetcher.go Outdated Show resolved Hide resolved

cmd/labs/project/fetcher.go Show resolved Hide resolved

review comments

2bcfa22

HariGS-DB requested a review from nfx as a code owner February 19, 2025 22:55

HariGS-DB and others added 2 commits February 19, 2025 23:08

Update settings.json

fcf3a43

Merge branch 'main' into feat/offlineinstall

17f4629

Merge branch 'main' into feat/offlineinstall

d8abfc4

pietern reviewed Feb 24, 2025

View reviewed changes

lennartkats-db and others added 8 commits February 28, 2025 12:53

Change warning about incomplete permissions section into a recommenda…

84ce54c

…tion (databricks#2043) ## Changes Changes the warning about an incomplete / implicit permissions section into a recommendation, and does a minor bit of cleanup. ## Tests New unit test.

Populate missing bundle config reference doc descriptions and fix res…

46b6a49

…ource reference doc template (databricks#2314) ## Changes - Added some missing descriptions to annotations.yml - Fixed links in the resource reference doc template ## Tests

add .idea to .gitignore (databricks#2375)

76d2b8f

## Changes 1. add ".idea" entry to ".gitgnore" ## Tests 1. manually checked that with this change files under .idea/ folder are not staged for commit

Simplify whl artifact autodetection code (databricks#2371)

2701c30

## Changes - Get rid of artifacts.DetectPackages which is a thin wrapper around artifacts/whl.DetectPackage - Get rid of parsing name out of setup.py. Do not randomize either, use a static one. ## Tests Existing tests.

andrewnester and others added 24 commits February 28, 2025 12:53

acc: Added tests for deploying PyPi and Maven libraries (databricks#2359

e9f9a4b

) ## Changes Added PyPi and Maven libraries tests Needed for this PR since we don't currently have any coverage for PyPi or Maven libraries databricks#2382

acc: Support multiline patterns in diff.py (databricks#2384)

485a738

## Changes Fix diff.py to apply replacements that have newlines in them. ## Tests Existing tests.

default-python: Swap order of yes/no in serverless template (databric…

d49e995

…ks#2386) ## Changes Since at this moment we set default to 'no', interactively it should also default to 'no'. However, it just uses the first option. ## Tests Manually running `cli bundle init default-python`

Skip serverless prompt in default-python (default is no) (databricks#…

1e3ff10

…2388) ## Tests Manually running 'bundle init default-python' - no question about serverless.

acc: Include full output for default-python/classic (databricks#2391)

29b3c61

## Tests Include full output of default-python/classic so it can be used as a base for diffs in cloud tests databricks#2383

Add warning when variable interpolation is used for auth fields (data…

5425401

…bricks#2399) ## Changes This PR adds a warning which gives users clear guidance when they try to use variable interpolation for an auth field. ## Tests Modify existing acceptance test.

updated review comments

9d5504a

Merge branch 'databricks:main' into feat/offlineinstall

7f1d010

review comments

839b28d

pietern requested a review from alexott March 3, 2025 07:55

alexott approved these changes Mar 6, 2025

View reviewed changes

HariGS-DB added 3 commits March 8, 2025 22:04

added comment in test to explain the scenario

5faed43

Merge branch 'main' into feat/offlineinstall

6038291

updated comment

2b5201f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable offline install of labs projects #2049

Enable offline install of labs projects #2049

HariGS-DB commented Dec 27, 2024 •

edited

Loading

alexott left a comment

HariGS-DB commented Feb 19, 2025

pietern Feb 24, 2025

HariGS-DB Feb 28, 2025

pietern Mar 3, 2025

HariGS-DB Mar 8, 2025

alexott left a comment

github-actions bot commented Mar 8, 2025

Enable offline install of labs projects #2049

Are you sure you want to change the base?

Enable offline install of labs projects #2049

Conversation

HariGS-DB commented Dec 27, 2024 • edited Loading

Changes

Tests

alexott left a comment

Choose a reason for hiding this comment

HariGS-DB commented Feb 19, 2025

pietern Feb 24, 2025

Choose a reason for hiding this comment

HariGS-DB Feb 28, 2025

Choose a reason for hiding this comment

pietern Mar 3, 2025

Choose a reason for hiding this comment

HariGS-DB Mar 8, 2025

Choose a reason for hiding this comment

alexott left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 8, 2025

HariGS-DB commented Dec 27, 2024 •

edited

Loading