Skip to content

Conversation

notauserx
Copy link
Contributor

@notauserx notauserx commented Nov 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Update logic to search by the lowercase of func_name. Uses unicode crate to facilitate searching function name ignoring case

fixes: #16737

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@notauserx notauserx changed the title add method to check sugar function fix: ignore case when matching function name Nov 22, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 22, 2024
@TCeason TCeason requested a review from andylokandy November 25, 2024 02:23
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notauserx
Copy link
Contributor Author

Does it make sense to add ignore case search in is_builtin_function(func_name) as well?

@sundy-li
Copy link
Member

Let's add a test in name_hit.test to cover the issue.

@notauserx notauserx force-pushed the fix-search-by-lowercase-func-name branch 2 times, most recently from f64459f to 5ad40f7 Compare November 27, 2024 15:58
@notauserx notauserx force-pushed the fix-search-by-lowercase-func-name branch from c08754d to d4bd725 Compare November 27, 2024 18:50
@notauserx
Copy link
Contributor Author

Let's add a test in name_hit.test to cover the issue.

Added a test

@BohuTANG
Copy link
Member

Hi @notauserx You can continue after fixing conflicts, we're nearly at the end :)

@sundy-li sundy-li enabled auto-merge December 27, 2024 01:55
@sundy-li sundy-li added this pull request to the merge queue Dec 27, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 27, 2024
@BohuTANG BohuTANG merged commit 0c94ab5 into databendlabs:main Dec 27, 2024
72 checks passed
@BohuTANG
Copy link
Member

@notauserx Thanks for your contribution.

@notauserx notauserx deleted the fix-search-by-lowercase-func-name branch May 19, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants