Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cookie and temp table #83

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

youngsofun
Copy link
Member

note:

temp table test is used to verify cookie works, but logout not supported in this pr, so if temp table is not auto drop at once when session ends, but can still get vaccumed. then it is better for user to still drop it manually

@youngsofun youngsofun force-pushed the fix branch 2 times, most recently from 450fc5b to 3949022 Compare December 3, 2024 23:29
Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

databend_py/connection.py Outdated Show resolved Hide resolved
@youngsofun
Copy link
Member Author

@hantmac plz return ci and merge

@sundy-li sundy-li mentioned this pull request Dec 7, 2024
@youngsofun
Copy link
Member Author

youngsofun commented Dec 11, 2024

@hantmac plz return ci and merge

believe the functionality provided by GlobalCookieJar already fulfills the requirements outlined in #33. Therefore, the persisted_cookies option could be deprecated and eventually removed in the future.
CC: @pengye91

@hantmac hantmac merged commit d29c4a3 into databendlabs:main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants