[internal-1486] logto version upgrade and use logto schema #671
+139
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evidence/d2e into SantanM/internal-1486_logto-schema
SantanM
commented
Feb 18, 2025
| @@ -452,6 +452,7 @@ services: | |||
| "+cdw_config": {}, | |||
| "+dataflow": {}, | |||
| "+db_credentials_mgr": {}, | |||
| "+logto": {}, | |||
There was a problem hiding this comment.
A schema for logto tables
SantanM
commented
Feb 18, 2025
| @@ -473,7 +474,9 @@ services: | |||
| "reader": "${PG_WRITE_USER:-alp_pg_write_user}", | |||
| "readerPassword": "${PG_WRITE_PASSWORD}", | |||
| "writer": "${PG_WRITE_USER:-alp_pg_write_user}", | |||
| "writerPassword": "${PG_WRITE_PASSWORD}" | |||
| "writerPassword": "${PG_WRITE_PASSWORD}", | |||
| "logtoManager": "${PG_LOGTO_MANAGER:-logto_postgres}", | |||
There was a problem hiding this comment.
PG user that manages logto schema. It has the following privileges - USAGE, CREATE and GRANT (can further grant privileges to other pg users) privileges.
SantanM
commented
Feb 18, 2025
| @@ -719,14 +725,14 @@ services: | |||
| entrypoint: | |||
| - sh | |||
| - -c | |||
| - npm run cli db seed -- --swe && npx @logto/cli db alteration deploy 1.18.0 && npm start | |||
| - npm start | |||
There was a problem hiding this comment.
see below alp-logto-seed
SantanM
commented
Feb 18, 2025
| @@ -735,6 +741,28 @@ services: | |||
| PROJECT_NAME: ${PROJECT_NAME:-d2e} | |||
| PORT: 3001 | |||
| TRUST_PROXY_HEADER: true | |||
| DATABASE_CONNECTION_TIMEOUT: 30000 | |||
|
|
|||
| alp-logto-seed: | |||
There was a problem hiding this comment.
Separate seeding and migration of logto schema to reduce the startup time of the container.
SantanM
commented
Feb 18, 2025
SantanM
commented
Feb 18, 2025
| @@ -123,6 +125,11 @@ export class App { | |||
| pgUsers.managerPassword, | |||
| "Manager" | |||
| ); | |||
| await this.userDao.createUserWithCreateRolePrivilege( | |||
There was a problem hiding this comment.
logtoManager will need privileges to create new roles. Logto database migrations include creation of logto_tenant_<db>_default/admin users.
SantanM
commented
Feb 18, 2025
| @@ -128,12 +148,15 @@ export default class PGUserDAO { | |||
| grantManagePrivilegesForSchema = async ( | |||
| client: any, | |||
| schemaName: string, | |||
| user: string | |||
| user: string, | |||
| withGrantOption: boolean | |||
There was a problem hiding this comment.
Flag - to allow the user to grant privileges to other users. logtoManage user needs the privileges to further grant rights to other users logto_tenant_<db>_default/admin.
SantanM
commented
Feb 18, 2025
| @@ -12,10 +12,10 @@ RUN npm add --location=global pnpm@^9.0.0 | |||
| RUN apk add --no-cache python3 make g++ rsync py3-setuptools git | |||
|
|
|||
| ## Git clone | |||
| RUN git clone --branch v1.18.0 https://github.com/logto-io/logto.git /etc/logto | |||
| # TODO: clone d2e logto instead of public repo | |||
…evidence/d2e into SantanM/internal-1486_logto-schema
SantanM
commented
Feb 19, 2025
satish-a0
approved these changes
Feb 19, 2025
satish-a0
reviewed
Feb 19, 2025
suwarnoong
approved these changes
Feb 19, 2025
SantanM
force-pushed
the
SantanM/internal-1486_logto-schema
branch
from
d87110f to
ffadfeb
Compare
SantanM
force-pushed
the
SantanM/internal-1486_logto-schema
branch
from
b542dac to
1edb5cf
Compare
mwaiyee
approved these changes
Feb 20, 2025
…evidence/d2e into SantanM/internal-1486_logto-schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR with relevant changes to the logto service is here.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)