Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify the behavior of clip() when one of the operands is NaN #813

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented Jun 5, 2024

This follows the NumPy behavior, where the result is nan if any operand is nan. I checked PyTorch and it seems to do this as well.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks very reasonable to me, thanks Aaron.

@rgommers rgommers added the Maintenance Bug fix, typo fix, or general maintenance. label Jun 13, 2024
@rgommers rgommers added this to the v2024 milestone Jun 13, 2024
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte changed the title Specify the behavior of clip() when one of the operands is nan docs: specify the behavior of clip() when one of the operands is NaN Sep 19, 2024
@kgryte kgryte added the Backport Changes involve backporting to previous versions. label Sep 19, 2024
@kgryte kgryte merged commit 8b0e405 into data-apis:main Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Changes involve backporting to previous versions. Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants