ENH: unary functions overhaul; better input validation #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Apr 23, 2025
| @@ -168,9 +231,6 @@ def _array_vals(): | |||
| for d in _floating_dtypes: | |||
| yield asarray(1.0, dtype=d) | |||
|
|
|||
| # Use the latest version of the standard so all functions are included | |||
| set_array_api_strict_flags(api_version="2024.12") | |||
There was a problem hiding this comment.
redundant with auto-applied fixture
ev-br
reviewed
Apr 23, 2025
| @pytest.mark.parametrize("func_name", elementwise_function_input_types) | ||
| def test_elementwise_function_vs_numpy_generics(func_name): | ||
| """ | ||
| Test that NumPy generics are explicitly disallowed. |
There was a problem hiding this comment.
Minor, trivial: instances of np.generic are typically referred to as numpy scalars. The fact that the type name is np.generic is... not very well known (for the better IMO). Anyway, this is not worth flushing the CI for.
ev-br
approved these changes
Apr 23, 2025
|
|
||
| _ = func(a, a) | ||
| with pytest.raises(TypeError, match="neither Array nor Python scalars"): | ||
| func(a, b) |
There was a problem hiding this comment.
If we want to be really thorough, can add also test func(b, a): unlike #103, functions we control.
| res = xp.where(cond, 1, x2) | ||
| assert res.device == device | ||
| res = xp.where(cond, x1, 2) | ||
| assert res.device == device |
There was a problem hiding this comment.
This and the following tests are great. I imaging we'll want to parrot them in array-api-tests at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #145
clip, andwherewhereis not an Arrayclip, andwherewhere