Skip to content

Fix regex warning #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix regex warning #650

wants to merge 2 commits into from

Conversation

River739
Copy link

[ ] Wrote test for feature
[ ] Added changes to CHANGELOG.md
[ ] Bumped version number (delete if unneeded)

Changes proposed:
<

  1. Fixed invalid regex escape sequence warning in "tests/test_formats.py" by using a raw string.
  2. Made "test_date_formatter_format_value" portable by skipping the test on platforms where "time.tzset()" is not available (e.g., Windows).

@coveralls
Copy link

Coverage Status

coverage: 94.978%. remained the same
when pulling 4f12671 on River739:fix-regex-warning
into 04a130e on data-8:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnanhemani adnanhemani Awaiting requested review from adnanhemani

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@River739 @coveralls