Skip to content

isort → ruff #9152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

isort → ruff #9152

wants to merge 2 commits into from

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Nov 19, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   9h 55m 42s ⏱️ - 4m 5s
 4 112 tests ±0   4 006 ✅  - 1    104 💤 ±0  2 ❌ +1 
51 516 runs  ±0  49 330 ✅  - 1  2 184 💤 ±0  2 ❌ +1 

For more details on these failures, see this check.

Results for commit 4b1f9d1. ± Comparison against base commit d8e3fd2.

♻️ This comment has been updated with latest results.

jacobtomlinson
jacobtomlinson reviewed Nov 20, 2025
View reviewed changes
pyproject.toml
Comment on lines -109 to -111
known_first_party = ["distributed"]
known_distributed = ["dask", "zict"]
Copy link
Member

@jacobtomlinson jacobtomlinson Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some config sections here have been lost. We intentionally separate first party packages. Is there an equivalent config with ruff?

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the one:

[tool.ruff.lint.isort]
known-first-party = ["dask"]

Forgot zict though.

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added zict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson left review comments

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimitriPapadopoulos @jacobtomlinson