-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Generic Openstack cloud provider #433
Add Generic Openstack cloud provider #433
Conversation
…nd added comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort here! Overall this PR looks great.
I don't have an openstack setup to test this against, but I'm happy to merge it in provided you've verified things work as expected.
As this contribution is a puppy I'd appreciate your commitment to continue maintaining this code and respond to issues and fix bugs in this integration. Are you happy to do that?
I have tested it against my own openstack installation and verified that it works. Of course openstack installations can vary and i will fix bugs if they emerge. Sure, i am happy to maintain and respond issues, fix bugs etc in the future. Cheers |
Awesome many thanks! |
Hello there 👋
This PR adds generic compatibility with (private/public) Openstack clouds, as long as they support application_credentials. I also tried to add some documentation and example configs.
Let me know if anything is missing/needs fixing.
Cheers!