Skip to content

WIP: Format imports in Rust code #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

andygrove
Copy link
Contributor

Changes in this PR:

  • Add rustfmt.toml with rules for formatting imports. These require cargo +nightly fmt
  • Add CI formatting check that runs cargo +nightly fmt
  • Disable formatting in pre-commit hook because it does not support +nightly (see [ENH] Find alternative to pre-commit-rust #810)
  • Formatting changes resulting from running cargo +nightly fmt

@codecov-commenter
Copy link

Codecov Report

Merging #811 (92ebe77) into main (94f96a0) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   74.88%   74.74%   -0.14%     
==========================================
  Files          71       71              
  Lines        3588     3588              
  Branches      748      748              
==========================================
- Hits         2687     2682       -5     
  Misses        771      771              
- Partials      130      135       +5     
Impacted Files Coverage Δ
dask_sql/physical/rel/custom/export_model.py 88.88% <0.00%> (-2.78%) ⬇️
dask_sql/physical/rel/logical/window.py 95.37% <0.00%> (-1.74%) ⬇️
dask_sql/_version.py 32.27% <0.00%> (-0.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygrove andygrove closed this Sep 27, 2022
@andygrove andygrove deleted the rust-fmt branch September 27, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants