feat(sdk): token and group queries #2449

shumkov · 2025-01-29T15:12:54Z

Issue being fixed or feature implemented

We need to support token and group queries in RS SDK

What was done?

Added token and group endpoints to RS dapi client
Derived serialization traits for some structs in DPP if the fixtures-and-mocks flag is enabled.
Added an optional method to call on the init chain to generate test data for RS SDK tests

How Has This Been Tested?

Implemented functional tests for new queries in RS SDK

Breaking Changes

None

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

I have assigned this pull request to a milestone

Summary by CodeRabbit

New Features
- Expanded support for token and group queries with additional request/response types.
- Introduced new query interfaces and endpoints for enhanced token balance, status, and total supply operations.
- Enabled conditional serialization for identity and token data in mock environments.
Tests
- Added comprehensive test suites for group actions, token information, and various fetch scenarios.
Chore / Dependency Updates
- Updated dependency features and build settings to support state-transition signing and compile-time optimizations.

coderabbitai · 2025-01-29T15:13:03Z

Walkthrough

The changes introduce expanded support for new token and group-related message types across several packages. Updates include modifications to constant arrays, multiple new gRPC request/response implementations, conditional serialization derives in the data processing packages, and enhanced error propagation in genesis state creation. Additionally, new modules and query structures are implemented in the proof verifier and SDK, accompanied by extensive unit tests. Several diagnostic files have been removed from the serialization derive package, and a constant function update was applied to the Identifier type.

Changes

File(s)	Change Summary
`packages/dapi-grpc/build.rs` `packages/rs-dapi-client/src/transport/grpc.rs`	Increased sizes of `VERSIONED_REQUESTS` and `VERSIONED_RESPONSES`; added six new request/response message types; added new `impl_transport_request_grpc!` implementations for token and group operations.
`packages/rs-dpp/src/balances/total_single_token_balance/mod.rs` `packages/rs-dpp/src/tokens/info/mod.rs` `packages/rs-dpp/src/tokens/info/v0/mod.rs`	Added conditional compilation attributes to derive serialization traits (`Encode`, `Decode`, `Serialize`, `Deserialize`) when the "fixtures-and-mocks" feature is enabled.
`packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/...`	Modified `create_genesis_state` error handling using the `?` operator; added new function `create_sdk_test_data` and methods in test modules to support group token queries and data creation.
`packages/rs-drive-proof-verifier/src/group_actions.rs` `packages/rs-drive-proof-verifier/src/tokens/...` `packages/rs-drive-proof-verifier/src/lib.rs`	Added new `FromProof` implementations for group actions and token proofs; defined type aliases; exposed new public modules (`group_actions`, `tokens`) to expand proof verification functionality.
`packages/rs-platform-serialization-derive/...`	Removed multiple diagnostic rustc ICE log files containing panic stack traces.
`packages/rs-platform-value/src/types/identifier.rs`	Updated `Identifier::new` to a constant function for compile-time evaluation.
`packages/rs-sdk/...` (Cargo.toml, README.md, src/mock, src/platform, tests/)	Added new feature dependencies (`dpp/fixtures-and-mocks`); updated dependency declarations and documentation; introduced new mock implementations, query structures, and modules for token balances, token info, token statuses, and group actions; extended tests to cover the new functionality.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant G as PlatformGrpcClient
    participant M as MappingConfig
    participant D as Drive (Proof Verifier)
    
    C->>G: Send new token/group request (e.g. GetTokenStatusesRequest)
    G->>M: Lookup supported VERSIONED_REQUESTS/RESPONSES
    M-->>G: Return updated message definitions
    G->>D: Process request and validate proofs (via FromProof implementations)
    D-->>G: Return verification result and metadata
    G->>C: Respond with corresponding message (e.g. GetTokenStatusesResponse)

sequenceDiagram
    participant P as Platform
    participant T as SDK Test Data Creator
    
    P->>P: Execute create_genesis_state()
    alt Error occurs
       P-->>P: Propagate error using "?"
    else
       P->>T: Optionally invoke create_sdk_test_data()
       T-->>P: Provide test data for group token queries
       P-->>P: Return Ok(())
    end

Possibly related PRs

feat: get proofs for tokens #2433: Introduced new token and group request types that directly relate to the added gRPC implementations in this PR.
feat(platform): proof verification for many queries and a few more queries #2431: Adjusted the VERSIONED_REQUESTS and response arrays alongside new RPC methods similar to those in this PR.
chore(platform): make bls sig compatibility an optional feature #2440: Implemented additional request/response handling for token and group data, aligning closely with the modifications presented here.

Suggested reviewers

QuantumExplorer

Poem

I hop through code with steady might,
Adding tokens, groups in flight.
Arrays grow, and proofs take form,
New queries rise amidst the storm.
A bunny's rhyme for changes bright,
Leaping into a future light!
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

shumkov · 2025-02-03T04:24:42Z

@CodeRabbit review

coderabbitai · 2025-02-03T04:24:48Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

shumkov · 2025-02-03T05:10:26Z

@CodeRabbit review

coderabbitai · 2025-02-03T05:10:31Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 5

🧹 Nitpick comments (25)

packages/rs-drive-proof-verifier/src/tokens/token_total_supply.rs (1)

30-35: Consider future-proofing version handling.

Currently, the code only handles Version::V0. If future versions are introduced, you may want to include a fallback match arm or a more explicit error message for unsupported versions.

packages/rs-drive-proof-verifier/src/tokens/token_status.rs (1)

36-45: Account for potential new versions.

Similar to the token total supply logic, consider adding a match arm for future versions, or provide an explicit error for unsupported versions to make this more robust.

packages/rs-sdk/src/platform/tokens/identity_token_balances.rs (2)

14-21: Consider validating non-empty token IDs.

If your business logic requires at least one token, add checks or return a more explicit error when token_ids is empty.

44-50: Validate identity IDs if needed.

If your use case mandates at least one identity, ensure the code handles an empty identity_ids array appropriately.

packages/rs-sdk/src/platform/group_actions.rs (1)

50-105: Potential code duplication among multiple queries
GroupInfosQuery and similar query structs below share a near-identical pattern of defining a struct with optional fields and implementing Query<...>. If code reuse or maintainability becomes an issue, consider a macro or templated approach to reduce boilerplate.

packages/rs-drive-proof-verifier/src/tokens/identity_token_balance.rs (1)

132-198: Consistent approach in multi-identity proof
The maybe_from_proof_with_metadata method follows the same robust verification pattern. The repeated logic might benefit from a shared utility function if this pattern continues in other modules.
packages/rs-drive-proof-verifier/src/tokens/token_info.rs (2)
85-85: Potential debug printing
There's a println! statement at line 85 that logs the proof in hex. Consider removing or gating it behind a debug feature flag to prevent unintentional large or sensitive logs in production.
-        println!("{:?}", hex::encode(&proof.grovedb_proof));
+        // println!("{:?}", hex::encode(&proof.grovedb_proof));
133-198: Robust multi-identity info verification
Again, the pattern of verifying the proof, mapping errors, and returning (Option<Self>, ResponseMetadata, Proof) is well-written. If you foresee more repeated proof-verification flows, refactoring into a shared helper might further optimize code reuse.
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs (3)
50-103: Consider splitting or renaming this function for improved clarity.

The create_data_for_group_token_queries function performs a variety of operations (identity registration, data contract creation, token minting, freezing, pausing, and adding group actions). This goes beyond simply "creating data." Splitting it into smaller functions or clarifying the name can help enhance readability and maintainability.

72-82: Clarify the comment on which token is being paused.

"Pause token 2" might be confusing if you are referring to the token indexed at TOKEN_ID_2. Currently, the code uses TOKEN_ID_1, which is the "second" token in a zero-based index. Consider adjusting the comment for consistency:
-        // Pause token 2
+        // Pause the second token (TOKEN_ID_1)
120-121: Confirm the handling of private keys.

There's a comment hinting that private keys may be printed, but no actual logging takes place. If printing or logging is needed for debugging, add the relevant code. Otherwise, remove or revise the comment to avoid confusion.
packages/rs-drive-proof-verifier/src/group_actions.rs (1)

87-167: Consider factoring out shared logic.

This logic for extracting request fields, verifying proofs, and mapping results repeats across the file. Extracting it into a helper method or utility could reduce duplication and enhance maintainability.
packages/rs-sdk/src/platform/tokens/mod.rs (1)
3-4: Fix incorrect documentation comment.

The documentation comment for token_info module is incorrect as it's a copy of the identity_token_balances module's comment.

Apply this diff to fix the documentation:
-/// Identity token balances queries
+/// Token information queries
packages/rs-drive-proof-verifier/src/tokens/mod.rs (1)
1-2: Maintain consistent module naming across packages.

The module name identity_token_balance (singular) in the proof verifier differs from identity_token_balances (plural) in the SDK. Consider using consistent naming to improve maintainability.

Apply this diff to align with the SDK's naming:
-pub mod identity_token_balance;
+pub mod identity_token_balances;
packages/rs-sdk/tests/fetch/tokens/token_total_supply.rs (1)

8-14: Consider adding more test cases.

While the test setup is correct, consider adding test cases for:

Invalid token IDs

Error handling scenarios

Edge cases with different supply values
packages/rs-sdk/src/platform/tokens/token_total_supply.rs (1)
7-20: Consider adding input validation.

While the Query implementation is correct, consider adding validation for the token ID before creating the request.
 impl Query<GetTokenTotalSupplyRequest> for Identifier {
     fn query(self, prove: bool) -> Result<GetTokenTotalSupplyRequest, Error> {
+        if self.is_empty() {
+            return Err(Error::InvalidInput("Token ID cannot be empty".into()));
+        }
         let request = GetTokenTotalSupplyRequest {
             version: Some(get_token_total_supply_request::Version::V0(
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/mod.rs (1)
17-32: Consider adding logging for test data generation.

While the implementation is correct, adding debug logs would help track test data generation during testing.
 pub(super) fn create_sdk_test_data(
     &self,
     block_info: &BlockInfo,
     transaction: TransactionArg,
     platform_version: &PlatformVersion,
 ) -> Result<(), Error> {
+    log::debug!("Creating SDK test data for local network");
     if self.config.network != Network::Regtest {
         return Err(Error::Execution(ExecutionError::CorruptedCodeExecution(
             "create_sdk_test_data must be called only on local network",
         )));
     }

     self.create_data_for_group_token_queries(block_info, transaction, platform_version)?;
+    log::debug!("SDK test data creation completed");

     Ok(())
 }
packages/rs-sdk/tests/fetch/tokens/token_status.rs (1)
21-22: Improve error handling in test expectation.

The current error message doesn't match the actual operation being performed.
     .await
-    .expect("fetch identity token infos");
+    .expect("fetch token statuses");
packages/rs-sdk/src/platform.rs (1)

3-6: Consider documenting new modules.

While the module additions align with the PR objectives, they should be documented similar to other modules in the file. Also, the TODO comment suggests a future refactor - consider creating a tracking issue.

Would you like me to help create a tracking issue for the TODO regarding proper user-facing API design?

Also applies to: 20-21
packages/rs-sdk/tests/fetch/group_actions.rs (2)
60-87: Consider removing the debug print statement.

The test effectively validates group fetching with pagination. However, the dbg! statement on line 78 should be removed as it's not necessary for the test.
-    dbg!(&groups);
126-156: Consider removing the debug print statement.

The test effectively validates group action fetching. However, the dbg! statement on line 148 should be removed as it's not necessary for the test.
-    dbg!(&group_actions);
packages/rs-sdk/src/mock/requests.rs (1)
287-424: Consider reducing code duplication in mock implementations.

The serialization/deserialization logic is very similar across IdentityTokenInfos, IdentitiesTokenInfos, TokenStatuses, and GroupActions. Consider extracting the common pattern into a macro or helper function.

Example macro approach:
macro_rules! impl_mock_response_for_retrieved_values {
    ($type:ty, $value_type:ty) => {
        impl MockResponse for $type {
            fn mock_serialize(&self, sdk: &MockDashPlatformSdk) -> Vec<u8> {
                let vec: Vec<(Identifier, Option<$value_type>)> =
                    self.iter().map(|(k, v)| (*k, v.clone())).collect();
                platform_encode_to_vec(vec, BINCODE_CONFIG, sdk.version())
                    .expect(concat!("encode ", stringify!($type)))
            }

            fn mock_deserialize(sdk: &MockDashPlatformSdk, buf: &[u8]) -> Self
            where
                Self: Sized,
            {
                let vec: Vec<(Identifier, Option<$value_type>)> =
                    platform_versioned_decode_from_slice(buf, BINCODE_CONFIG, sdk.version())
                        .expect(concat!("decode ", stringify!($type)));
                RetrievedValues::from_iter(vec)
            }
        }
    };
}

// Usage:
impl_mock_response_for_retrieved_values!(IdentityTokenInfos, IdentityTokenInfo);
impl_mock_response_for_retrieved_values!(IdentitiesTokenInfos, IdentityTokenInfo);
impl_mock_response_for_retrieved_values!(TokenStatuses, TokenStatus);
impl_mock_response_for_retrieved_values!(GroupActions, GroupAction);
packages/rs-sdk/Cargo.toml (1)

62-63: Track the TODO comment about removing features from default.

The comment indicates that mocks and offline-testing should be removed from default features in the future.

Would you like me to create an issue to track this technical debt?

packages/rs-sdk/README.md (2)

96-98: Clarify Test Vector Generation Instructions

The updated steps clearly instruct developers to (1) uncomment the create_sdk_test_data(...) call, (2) run the generate_test_vectors.sh script, and (3) optionally commit the generated vectors.

Suggestion: Consider adding a brief note clarifying whether generated test vector files should be committed or ignored (for example, via a .gitignore rule) to prevent accidental pollution of the repository.

146-147: Review Duplicate Checklist Steps

The checklist now contains duplicate instructions for:

Uncommenting create_sdk_test_data(...) (see step 2 on line 96 and step 15 on line 146), and

Generating test vectors (step 3 on line 97 versus step 16 on line 147).

Please confirm whether both occurrences are necessary or if these steps can be consolidated to avoid confusion.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93f7d44 and 27bf8bf.

📒 Files selected for processing (82)

packages/dapi-grpc/build.rs (3 hunks)
packages/rs-dapi-client/src/transport/grpc.rs (1 hunks)
packages/rs-dpp/src/balances/total_single_token_balance/mod.rs (1 hunks)
packages/rs-dpp/src/tokens/info/mod.rs (2 hunks)
packages/rs-dpp/src/tokens/info/v0/mod.rs (1 hunks)
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/mod.rs (2 hunks)
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/mod.rs (1 hunks)
packages/rs-drive-abci/src/execution/platform_events/initialization/create_genesis_state/test/tokens.rs (1 hunks)
packages/rs-drive-proof-verifier/Cargo.toml (1 hunks)
packages/rs-drive-proof-verifier/src/group_actions.rs (1 hunks)
packages/rs-drive-proof-verifier/src/lib.rs (1 hunks)
packages/rs-drive-proof-verifier/src/tokens/identity_token_balance.rs (1 hunks)
packages/rs-drive-proof-verifier/src/tokens/mod.rs (1 hunks)
packages/rs-drive-proof-verifier/src/tokens/token_info.rs (1 hunks)
packages/rs-drive-proof-verifier/src/tokens/token_status.rs (1 hunks)
packages/rs-drive-proof-verifier/src/tokens/token_total_supply.rs (1 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_33_46-3251.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_00-10108.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_04-10384.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_08-10643.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_12-10937.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_20-11458.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_23-11733.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_25-11999.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_26-12247.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_28-12710.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_29-12958.txt (0 hunks)
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_30-13195.txt (0 hunks)
packages/rs-platform-value/src/types/identifier.rs (1 hunks)
packages/rs-sdk/Cargo.toml (2 hunks)
packages/rs-sdk/README.md (3 hunks)
packages/rs-sdk/src/mock/requests.rs (6 hunks)
packages/rs-sdk/src/mock/sdk.rs (1 hunks)
packages/rs-sdk/src/platform.rs (1 hunks)
packages/rs-sdk/src/platform/group_actions.rs (1 hunks)
packages/rs-sdk/src/platform/tokens/identity_token_balances.rs (1 hunks)
packages/rs-sdk/src/platform/tokens/mod.rs (1 hunks)
packages/rs-sdk/src/platform/tokens/token_info.rs (1 hunks)
packages/rs-sdk/src/platform/tokens/token_status.rs (1 hunks)
packages/rs-sdk/src/platform/tokens/token_total_supply.rs (1 hunks)
packages/rs-sdk/tests/fetch/config.rs (3 hunks)
packages/rs-sdk/tests/fetch/contested_resource_vote_state.rs (1 hunks)
packages/rs-sdk/tests/fetch/generated_data.rs (1 hunks)
packages/rs-sdk/tests/fetch/group_actions.rs (1 hunks)
packages/rs-sdk/tests/fetch/mod.rs (1 hunks)
packages/rs-sdk/tests/fetch/tokens/identity_token_balances.rs (1 hunks)
packages/rs-sdk/tests/fetch/tokens/mod.rs (1 hunks)
packages/rs-sdk/tests/fetch/tokens/token_info.rs (1 hunks)
packages/rs-sdk/tests/fetch/tokens/token_status.rs (1 hunks)
packages/rs-sdk/tests/fetch/tokens/token_total_supply.rs (1 hunks)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/data_contract-e668c659af66aee1e72c186dde7b5b7e0a1d712a09c40d5721f622bf53c53155.json (1 hunks)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1 hunks)
packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json (0 hunks)

⛔ Files not processed due to max files limit (31)

packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_identity_balance_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_identity_balance_revision_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_identity_contract_no_nonce_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_identity_public_keys_all_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_identity_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_identity_read_by_key/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_identity_token_info/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_multiple_identities_token_balances/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_multiple_identities_with_unknown_token_balance/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_multiple_identity_token_balances/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_prefunded_specialized_balance_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_protocol_version_vote_count/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_protocol_version_votes_limit_2/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_protocol_version_votes_none/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_protocol_version_votes_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_protocol_version_votes_zeros/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_token_status/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json
packages/rs-sdk/tests/vectors/test_token_total_supply/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json

💤 Files with no reviewable changes (28)

packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_epoch_fetch_current/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_epoch_list/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/document_list_document_query/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/document_read_no_contract/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_33_46-3251.txt
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_04-10384.txt
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_00-10108.txt
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_20-11458.txt
packages/rs-sdk/tests/vectors/document_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_23-11733.txt
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_12-10937.txt
packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_epoch_list_limit/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_08-10643.txt
packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-029045172fbebcf97290db8879490a48ac0d1d60e249d031b5ad79e3e46e3fca.json
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_25-11999.txt
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_29-12958.txt
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_26-12247.txt
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_30-13195.txt
packages/rs-platform-serialization-derive/rustc-ice-2024-02-20T10_35_28-12710.txt

✅ Files skipped from review due to trivial changes (1)

packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/data_contract-e668c659af66aee1e72c186dde7b5b7e0a1d712a09c40d5721f622bf53c53155.json

🧰 Additional context used

📓 Learnings (9)

packages/rs-sdk/tests/vectors/contested_resource_vote_states_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)

Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.

packages/rs-sdk/tests/vectors/document_list_drive_query/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)

Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.

packages/rs-sdk/tests/vectors/document_read_no_document/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)

Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.

packages/rs-sdk/tests/vectors/test_data_contract_read/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)

Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.

packages/rs-sdk/tests/vectors/test_data_contract_read_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)

Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.

packages/rs-sdk/tests/vectors/test_data_contracts_1_ok_1_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)

Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.

packages/rs-sdk/tests/vectors/test_data_contracts_2_nx/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)

Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.

packages/rs-sdk/tests/vectors/test_epoch_fetch/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)

Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.

packages/rs-sdk/tests/vectors/test_epoch_fetch_future/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json (1)

Learnt from: lklimek
PR: dashpay/platform#2030
File: packages/rs-sdk/tests/vectors/test_asset_lock_proof/quorum_pubkey-100-4ce7fd81273c2b394c0f32367374fc5b09ba912e017aacb366d2171e9ca6f9d5.json:1-1
Timestamp: 2024-12-10T10:56:26.215Z
Learning: In the `packages/rs-sdk/tests/vectors/test_asset_lock_proof/` directory, files with the `.json` extension are mock data that may not follow standard JSON format; this is intentional and acceptable within the project's testing framework.

🪛 Biome (1.9.4)

packages/rs-sdk/tests/vectors/contested_resource_identity_votes_not_found/quorum_pubkey-106-1e36eadee30940f5c42271ceb15ed97c58eb057410158b392ceec4d4631eff63.json