Unable to download artifact(s): Artifact not found for name: js-build-2f03bed07f2888377e84a0db0dc3e0174c5c4b2e Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact. For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

CodeQL Action major versions v1 and v2 have been deprecated. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2025-01-10-code-scanning-codeql-action-v2-is-now-deprecated/

warning: the following explicit lifetimes could be elided: 'a --> packages/rs-dpp/src/data_contract/document_type/accessors/mod.rs:153:6 | 153 | impl<'a> DocumentTypeV0Getters for DocumentTypeRef<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 153 - impl<'a> DocumentTypeV0Getters for DocumentTypeRef<'a> { 153 + impl DocumentTypeV0Getters for DocumentTypeRef<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> packages/rs-dpp/src/data_contract/document_type/accessors/mod.rs:287:6 | 287 | impl<'a> DocumentTypeV0Getters for DocumentTypeMutRef<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 287 - impl<'a> DocumentTypeV0Getters for DocumentTypeMutRef<'a> { 287 + impl DocumentTypeV0Getters for DocumentTypeMutRef<'_> { |

warning: unneeded `return` statement --> packages/rs-dpp/src/data_contract/document_type/property/array.rs:73:9 | 73 | / return match self { 74 | | ArrayItemType::String(_, _) => { 75 | | let value_as_text = value.as_text().ok_or_else(get_field_type_matching_error)?; 76 | | let vec = value_as_text.as_bytes().to_vec(); ... | 118 | | } 119 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 73 ~ match self { 74 + ArrayItemType::String(_, _) => { 75 + let value_as_text = value.as_text().ok_or_else(get_field_type_matching_error)?; 76 + let vec = value_as_text.as_bytes().to_vec(); 77 + let mut r_vec = vec.len().encode_var_vec(); 78 + r_vec.extend(vec); 79 + Ok(r_vec) 80 + } 81 + ArrayItemType::Date => { 82 + let value_as_f64 = value.to_float().map_err(ProtocolError::ValueError)?; 83 + let value_bytes = value_as_f64.to_be_bytes().to_vec(); 84 + Ok(value_bytes) 85 + } 86 + ArrayItemType::Integer => { 87 + let value_as_i64: i64 = value.to_integer().map_err(ProtocolError::ValueError)?; 88 + let value_bytes = value_as_i64.to_be_bytes().to_vec(); 89 + Ok(value_bytes) 90 + } 91 + ArrayItemType::Number => { 92 + let value_as_f64 = value.to_float().map_err(ProtocolError::ValueError)?; 93 + let value_bytes = value_as_f64.to_be_bytes().to_vec(); 94 + Ok(value_bytes) 95 + } 96 + ArrayItemType::ByteArray(_, _) => { 97 + let mut bytes = value.to_binary_bytes()?; 98 + 99 + let mut r_vec = bytes.len().encode_var_vec(); 100 + r_vec.append(&mut bytes); 101 + Ok(r_vec) 102 + } 103 + ArrayItemType::Identifier => { 104 + let mut bytes = value.to_identifier_bytes()?; 105 + 106 + let mut r_vec = bytes.len().encode_var_vec(); 107 + r_vec.append(&mut bytes); 108 + Ok(r_vec) 109 + } 110 + ArrayItemType::Boolean => { 111 + let value_as_boolean = value.as_bool().ok_or_else(get_field_type_matching_error)?; 112 + // 0 means does not exist 113 + if value_as_boolean { 114 + Ok(vec![1]) // 1 is true 115 + } else { 116 + Ok(vec![0]) // 2 is false 117 + } 118 + } 119 ~ } |

warning: unneeded `return` statement --> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:986:9 | 986 | / return match self { 987 | | DocumentPropertyType::String(_) => { 988 | | let value_as_text = value 989 | | .as_text() ... | 1128 | | )), 1129 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 986 ~ match self { 987 + DocumentPropertyType::String(_) => { 988 + let value_as_text = value 989 + .as_text() 990 + .ok_or_else(|| get_field_type_matching_error(value))?; 991 + let vec = value_as_text.as_bytes().to_vec(); 992 + let mut r_vec = vec.len().encode_var_vec(); 993 + r_vec.extend(vec); 994 + Ok(r_vec) 995 + } 996 + // TODO: Make the same as in https://github.com/dashpay/platform/blob/8d2a9e54d62b77581c44a15a09a2c61864af37d3/packages/rs-dpp/src/document/v0/serialize.rs#L161 997 + // it must be u64 BE. Markers are wrong here as well 998 + DocumentPropertyType::Date => { 999 + let value_as_f64 = value.to_float().map_err(ProtocolError::ValueError)?; 1000 + let mut value_bytes = value_as_f64.to_be_bytes().to_vec(); 1001 + if required { 1002 + Ok(value_bytes) 1003 + } else { 1004 + // if the value wasn't required we need to add a byte to prove it existed 1005 + let mut r_vec = vec![255u8]; 1006 + r_vec.append(&mut value_bytes); 1007 + Ok(r_vec) 1008 + } 1009 + } 1010 + DocumentPropertyType::U128 => { 1011 + let value_as_u128: u128 = value.to_integer().map_err(ProtocolError::ValueError)?; 1012 + Ok(value_as_u128.to_be_bytes().to_vec()) 1013 + } 1014 + DocumentPropertyType::I128 => { 1015 + let value_as_i128: i128 = value.to_integer().map_err(ProtocolError::ValueError)?; 1016 + Ok(value_as_i128.to_be_bytes().to_vec()) 1017 + } 1018 + DocumentPropertyType::U64 => { 1019 + let value_as_u64: u64 = value.to_integer().map_err(ProtocolError::ValueError)?; 1020 + Ok(value_as_u64.to_be_bytes().to_vec()) 1021 + } 1022 + DocumentPropertyType::I64 => { 1023 + let value_as_i64: i64 = value.to_integer().map_err(ProtocolError::ValueError)?; 1024 + Ok(value_as_i64.to_be_bytes().to_vec()) 1025 + } 1026 + DocumentPropertyType::U32 => { 1027 + let value_as_u32: u32 = value.to_integer().map_err(ProtocolError::ValueError)?; 1028 + Ok(value_as_u32.to_be_bytes().to_vec()) 1029 + } 1030 + DocumentPropertyType::I32 => { 1031 + let value_as_i32: i32 = value.to_integer().map_err(ProtocolError::ValueError)?; 1032 + Ok(value_as_i32.to_be_bytes().to_vec()) 1033 + } 1034 + DocumentPropertyType::U16 => { 1035 + let value_as_u16: u16 = value.to_integer().map_err(ProtocolError::ValueError)?; 1036 + Ok(value_as_u16.to_be_bytes().to_vec()) 1037 + } 1038 + DocumentPropertyType::I16 => { 1039 + let value_as_i16: i16 = value.to_integer().map_err(ProtocolError::ValueError)?; 1040 + Ok(value_as_i16.to_be_bytes().to_vec()) 1041 + } 1042 + DocumentPropertyType::U8 => { 1043 + let value_as_u8: u8 = value.to_integer().map_err(ProtocolError::ValueError)?; 1044 + Ok(value_as_u8.to_be_bytes().to_vec()) 1045 + } 1046 + DocumentPropertyType::I8 => {

warning: taken reference of right operand --> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:1234:20 | 1234 | if value == &vec![0] { | ^^^^^^^^^-------- | | | help: use the right value directly: `...` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default

warning: taken reference of right operand --> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:1325:20 | 1325 | if value == &vec![0] { | ^^^^^^^^^-------- | | | help: use the right value directly: `...` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

warning: taken reference of right operand --> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:1327:27 | 1327 | } else if value == &vec![1] { | ^^^^^^^^^-------- | | | help: use the right value directly: `...` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

warning: the following explicit lifetimes could be elided: 'de --> packages/rs-dpp/src/data_contract/document_type/index/mod.rs:99:14 | 99 | impl<'de> Visitor<'de> for FieldVisitor { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 99 - impl<'de> Visitor<'de> for FieldVisitor { 99 + impl Visitor<'_> for FieldVisitor { |

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> packages/rs-dpp/src/data_contract/document_type/index/mod.rs:157:1 | 157 | / impl PartialOrd for ContestedIndexFieldMatch { 158 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 159 | || use ContestedIndexFieldMatch::*; 160 | || match (self, other) { 161 | || // Comparing two integers ... || 170 | || } 171 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 172 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default

warning: `to_string` applied to a type that implements `Display` in `format!` args --> packages/rs-dpp/src/data_contract/document_type/index/mod.rs:503:66 | 503 | ... e.to_string() | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[warn(clippy::to_string_in_format_args)]` on by default

warning: unused import: `platform_value::Identifier` --> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/v0/v0_methods.rs:11:5 | 11 | use platform_value::Identifier; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: unused import: `crate::state_transition::GetDataContractSecurityLevelRequirementFn` --> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/v0/v0_methods.rs:15:5 | 15 | use crate::state_transition::GetDataContractSecurityLevelRequirementFn; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: this `else { if .. }` block can be collapsed --> packages/rs-drive/src/query/mod.rs:1324:16 | 1324 | } else { | ________________^ 1325 | | if let Some(start_at_key) = start_at_key { 1326 | | inner_query.insert_range_to(..start_at_key); 1327 | | } else { ... | 1331 | | } 1332 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 1324 ~ } else if let Some(start_at_key) = start_at_key { 1325 + inner_query.insert_range_to(..start_at_key); 1326 + } else { 1327 + //todo: really not sure if this is correct 1328 + // Should investigate more 1329 + inner_query.insert_key(vec![]); 1330 + } |

warning: doc list item without indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:26:9 | 26 | /// start fetching the contract's history. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 26 | /// start fetching the contract's history. | ++

warning: doc list item without indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:29:9 | 29 | /// to return. If `None`, the limit is set to 10. Should be between 1 and 10. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 29 | /// to return. If `None`, the limit is set to 10. Should be between 1 and 10. | ++

warning: doc list item without indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:32:9 | 32 | /// before starting to return them. If `None`, no entries are skipped. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 32 | /// before starting to return them. If `None`, no entries are skipped. | ++

warning: doc list item without indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:37:9 | 37 | /// a `BTreeMap` with Unix timestamp as the key and contract as the value, representing | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 37 | /// a `BTreeMap` with Unix timestamp as the key and contract as the value, representing | ++

warning: doc list item without indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:38:9 | 38 | /// the contract's history. The `Err` variant contains an `Error` in case of a failure. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 38 | /// the contract's history. The `Err` variant contains an `Error` in case of a failure. | ++

warning: doc list item without indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/v0/mod.rs:45:9 | 45 | /// contract history. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 45 | /// contract history. | ++

warning: doc list item without indentation --> packages/rs-drive/src/drive/contract/get_fetch/fetch_contract_with_history/mod.rs:22:9 | 22 | /// start fetching the contract's history. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 22 | /// start fetching the contract's history. | ++

warning: unused import: `crate::utils::ToSerdeJSONExt` --> packages/wasm-dpp/src/metadata.rs:6:5 | 6 | use crate::utils::ToSerdeJSONExt; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: unused import: `dpp::util::json_value::JsonValueExt` --> packages/wasm-dpp/src/metadata.rs:9:5 | 9 | use dpp::util::json_value::JsonValueExt; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> packages/wasm-dpp/src/metadata.rs:82:9 | 82 | self.0.time_ms as u64 | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.time_ms` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`u32` -> `u32`) --> packages/wasm-dpp/src/metadata.rs:87:9 | 87 | self.0.protocol_version as u32 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.protocol_version` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: bound is defined in more than one place --> packages/wasm-dpp/src/utils.rs:25:24 | 25 | fn with_serde_into<D: DeserializeOwned>(&self) -> Result<D, JsValue> | ^ 26 | where 27 | D: for<'de> serde::de::Deserialize<'de> + 'static; | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default

warning: methods `with_serde_to_platform_value_map` and `with_serde_into` are never used --> packages/wasm-dpp/src/utils.rs:24:8 | 19 | pub trait ToSerdeJSONExt { | -------------- methods in this trait ... 24 | fn with_serde_to_platform_value_map(&self) -> Result<BTreeMap<String, Value>, JsValue>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 25 | fn with_serde_into<D: DeserializeOwned>(&self) -> Result<D, JsValue> | ^^^^^^^^^^^^^^^

warning: methods `into_inner` and `inner_mut` are never used --> packages/wasm-dpp/src/utils.rs:287:8 | 284 | pub(crate) trait Inner { | ----- methods in this trait ... 287 | fn into_inner(self) -> Self::InnerItem; | ^^^^^^^^^^ 288 | fn inner(&self) -> &Self::InnerItem; 289 | fn inner_mut(&mut self) -> &mut Self::InnerItem; | ^^^^^^^^^

warning: unused import: `std::str::FromStr` --> packages/wasm-dpp/src/document/factory.rs:27:5 | 27 | use std::str::FromStr; | ^^^^^^^^^^^^^^^^^

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/wasm-dpp/src/document/factory.rs:158:24 | 158 | let documents: Vec<( | ________________________^ 159 | | DocumentTransitionActionType, 160 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 161 | | )> = documents_by_action | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

warning: use of a fallible conversion when an infallible one could be used --> packages/wasm-dpp/src/document/factory.rs:327:27 | 327 | let documents_array = js_sys::Array::try_from(documents_with_action) | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `JsValue` to `Array` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default

warning: unused import: `crate::util::type_constants::DEFAULT_HASH_SIZE_U8` --> packages/rs-drive/src/drive/document/paths.rs:2:5 | 2 | use crate::util::type_constants::DEFAULT_HASH_SIZE_U8; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters` --> packages/rs-drive/src/drive/document/paths.rs:3:5 | 3 | use dpp::data_contract::document_type::accessors::DocumentTypeV0Getters; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods` --> packages/rs-drive/src/drive/document/paths.rs:4:5 | 4 | use dpp::data_contract::document_type::methods::DocumentTypeV0Methods; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `dpp::data_contract::document_type::DocumentTypeRef` --> packages/rs-drive/src/drive/document/paths.rs:5:5 | 5 | use dpp::data_contract::document_type::DocumentTypeRef; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: function `contract_documents_primary_key_path` is never used --> packages/rs-drive/src/drive/document/paths.rs:41:15 | 41 | pub(crate) fn contract_documents_primary_key_path<'a>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused import: `identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0` --> packages/rs-drive/src/drive/identity/key/fetch/mod.rs:16:9 | 16 | identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `crate::drive::votes::resolved::vote_polls::contested_document_resource_vote_poll::ContestedDocumentResourceVotePollWithContractInfo` --> packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs:3:5 | 3 | use crate::drive::votes::resolved::vote_polls::contested_document_resource_vote_poll::ContestedDocumentResourceVotePollWithContractInfo; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `crate::drive::Drive` --> packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs:6:5 | 6 | use crate::drive::Drive; | ^^^^^^^^^^^^^^^^^^^

warning: unused import: `crate::util::object_size_info::DataContractOwnedResolvedInfo` --> packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs:11:5 | 11 | use crate::util::object_size_info::DataContractOwnedResolvedInfo; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `platform_version::version::PlatformVersion` --> packages/rs-drive/src/drive/votes/resolved/vote_polls/contested_document_resource_vote_poll/resolve.rs:20:5 | 20 | use platform_version::version::PlatformVersion; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `platform_value::Identifier` --> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/v0/v0_methods.rs:11:5 | 11 | use platform_value::Identifier; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: unused import: `crate::state_transition::GetDataContractSecurityLevelRequirementFn` --> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_transfer_transition/v0/v0_methods.rs:15:5 | 15 | use crate::state_transition::GetDataContractSecurityLevelRequirementFn; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: this `else { if .. }` block can be collapsed --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:268:24 | 268 | } else { | ________________________^ 269 | | if let Some((_, found_old_key)) = identity_to_enable_old_keys 270 | | .iter() 271 | | .find(|(_, key)| key.purpose() == Purpose::TRANSFER) ... | 282 | | } 283 | | }; | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 268 ~ } else if let Some((_, found_old_key)) = identity_to_enable_old_keys 269 + .iter() 270 + .find(|(_, key)| key.purpose() == Purpose::TRANSFER) 271 + { 272 + Some(found_old_key.data().to_vec().try_into().map_err(|_| { 273 + Error::Execution(ExecutionError::CorruptedDriveResponse( 274 + "old payout address should be 20 bytes".to_string(), 275 + )) 276 + })?) 277 + } else { 278 + // finally we just use the old masternode payout address 279 + // we need to use the old pub_key_operator 280 + old_masternode.state.operator_payout_address 281 ~ }; |

warning: the `Err`-variant returned from this function is very large --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:44:10 | 44 | ) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^ | ::: packages/rs-drive-abci/src/error/mod.rs:28:5 | 28 | Abci(#[from] AbciError), | ----------------------- the largest variant contains at least 208 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: taken reference of right operand --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:323:42 | 323 | .find(|(_, key)| key.data().as_slice() == &new_payout_address) | ^^^^^^^^^^^^^^^^^^^^^^^^^------------------- | | | help: use the right value directly: `new_payout_address` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default

warning: taken reference of right operand --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:347:42 | 347 | .find(|(_, key)| key.data().as_slice() == &new_platform_node_id) | ^^^^^^^^^^^^^^^^^^^^^^^^^--------------------- | | | help: use the right value directly: `new_platform_node_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

warning: unused import: `prefunded_specialized_balances_for_voting_path` --> packages/rs-drive-abci/src/execution/platform_events/protocol_upgrade/perform_events_on_first_block_of_protocol_change/v0/mod.rs:24:5 | 24 | prefunded_specialized_balances_for_voting_path, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: the `Err`-variant returned from this function is very large --> packages/rs-drive-abci/src/execution/platform_events/protocol_upgrade/perform_events_on_first_block_of_protocol_change/v0/mod.rs:60:10 | 60 | ) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^ | ::: packages/rs-drive-abci/src/error/mod.rs:28:5 | 28 | Abci(#[from] AbciError), | ----------------------- the largest variant contains at least 208 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: the `Err`-variant returned from this function is very large --> packages/rs-drive-abci/src/execution/platform_events/protocol_upgrade/perform_events_on_first_block_of_protocol_change/v0/mod.rs:101:10 | 101 | ) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^ | ::: packages/rs-drive-abci/src/error/mod.rs:28:5 | 28 | Abci(#[from] AbciError), | ----------------------- the largest variant contains at least 208 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

warning: the `Err`-variant returned from this function is very large --> packages/rs-drive-abci/src/execution/platform_events/protocol_upgrade/perform_events_on_first_block_of_protocol_change/v0/mod.rs:122:10 | 122 | ) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^ | ::: packages/rs-drive-abci/src/error/mod.rs:28:5 | 28 | Abci(#[from] AbciError), | ----------------------- the largest variant contains at least 208 bytes | = help: try reducing the size of `error::Error`, for example by boxing large elements or replacing it with `Box<error::Error>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

The type 'BlockHeader' is undefined

Missing JSDoc @param "firstHeaderHeight" type

Invalid JSDoc @param "reject" type "function"; prefer: "Function"

Missing JSDoc @Property "maxParallelStreams" description

Missing JSDoc @Property "targetBatchSize" description

Missing JSDoc @Property "maxRetries" description

Missing JSDoc @param "options" description

Missing JSDoc @param "createHistoricalSyncStream" description

Missing JSDoc @param "createHistoricalSyncStream" type

Missing JSDoc @param "createContinuousSyncStream" description

Unexpected console statement

Dependency cycle via ./Platform:1

Using exported name 'Client' as identifier for default export

Dependency cycle via ./Platform:10

Using exported name 'Client' as identifier for default export

Dependency cycle detected

Using exported name 'createAssetLockTransaction' as identifier for default export

Dependency cycle detected

Dependency cycle detected

Dependency cycle detected

Dependency cycle detected

100% - 60 hits, 0 misses, 0 errors

100% - 292 hits, 0 misses, 0 errors

100% - 190 hits, 0 misses, 0 errors

100% - 174 hits, 0 misses, 0 errors

100% - 226 hits, 0 misses, 0 errors

100% - 215 hits, 0 misses, 0 errors

100% - 60 hits, 0 misses, 0 errors

100% - 60 hits, 0 misses, 0 errors

100% - 60 hits, 0 misses, 0 errors

100% - 60 hits, 0 misses, 0 errors

100% - 196 hits, 0 misses, 0 errors

100% - 410 hits, 0 misses, 0 errors

100% - 434 hits, 0 misses, 0 errors

100% - 195 hits, 0 misses, 0 errors

100% - 218 hits, 0 misses, 0 errors

100% - 352 hits, 0 misses, 0 errors

100% - 202 hits, 0 misses, 0 errors

100% - 203 hits, 0 misses, 0 errors

100% - 60 hits, 0 misses, 0 errors

100% - 545 hits, 1 misses, 0 errors

100% - 209 hits, 0 misses, 0 errors

100% - 60 hits, 0 misses, 0 errors

100% - 1040 hits, 0 misses, 0 errors

100% - 428 hits, 0 misses, 0 errors

100% - 203 hits, 0 misses, 0 errors

100% - 887 hits, 0 misses, 0 errors

100% - 434 hits, 0 misses, 0 errors