-
Notifications
You must be signed in to change notification settings - Fork 109
feat: override LLMQ params #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an option to override default LLMQ parameters by adding an optional llmqParamsOverride argument across various classes. Key changes include:
- Adding llmqParamsOverride to payload parsing in CommitmentTxPayload.
- Propagating llmqParamsOverride in SimplifiedMNListDiff and SimplifiedMNList helper functions.
- Modifying QuorumEntry and constants to support quorum parameter overrides.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
lib/transaction/payload/commitmenttxpayload.js | Updated fromBuffer to accept and pass llmqParamsOverride to QuorumEntry.getParams. |
lib/deterministicmnlist/SimplifiedMNListDiff.js | Added llmqParamsOverride parameter to constructors and parsing functions (fromBuffer, fromObject, fromHexString, fromJSON). |
lib/deterministicmnlist/SimplifiedMNList.js | Propagated llmqParamsOverride through the constructor and related methods. |
lib/deterministicmnlist/QuorumEntry.js | Revised constructor and helper methods to handle llmqParamsOverride and merged parameters using _.merge. |
lib/constants/index.js | Defined LLMQ_TYPE_PARAMS to centralize default quorum parameters. |
Comments suppressed due to low confidence (1)
lib/deterministicmnlist/QuorumEntry.js:75
- The check 'if (arg instanceof QuorumEntry)' is repeated in the constructor. Removing the duplicate check can simplify the logic and improve clarity.
if (arg instanceof QuorumEntry) {
Issue being fixed or feature implemented
We use custom quorum params for the local network in order to use only one masternode instead of 3
What was done?
How Has This Been Tested?
As a part of test suite
Breaking Changes
None
Checklist: