Avoid "cannot open" messages #18
Closed
+68
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the expression to determine the null device and uses the existing Elisp variable null-device instead. This commit also fixes a naming error with one of the unit tests. There were two unit tests with the same name so one of them wasn't picked up...
swinkels
changed the title
|
I'm closing this pull request as the solution is somewhat overengineered :). It turns out that pre-3.34.0 versions of SQLite also accept the null device, which makes the change a lot less elaborate. See pull request #11 for a one-line change with the same result :). In any case, I learned something from it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses ticket #17 , that reports that the user sees many
cannot open: "''"messages.This issue is caused by a change in SQLite. To avoid any initialization when SQLite runs a command, dash-docs calls SQlite with the
-initoption. For SQLite versions older than 3.34.0, you would use arguments-init "". As of that version, SQLite reports the error that file'"doesn't exist and you need to pass the null device instead.This pull request checks the SQLite version in-use and provides the appropriate version of the arguments.