Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few diagnostics in anticipation of lints v5 #2525

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

parlough
Copy link
Member

@parlough parlough commented Nov 22, 2024

Some packages don't have a high enough SDK constraint to update to v5 of package:lints, so this PR fixes some of the resulting diagnostics in anticipation of eventually making that update.

@parlough
Copy link
Member Author

parlough commented Dec 5, 2024

\cc @jyameo for review :)

This PR updates some doc comments to account for upcoming additions to package:lints. The changelog-not-required label is also required, but I don't have access to add it. Thanks!

Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @parlough

@parlough
Copy link
Member Author

I can't merge, so feel free to land when ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants