-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Effective Dart Design Guidelines to Reflect Dart 3.0 Class Modifiers #6449
Merged
+15
−11
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a2b98a2
### Summary of Changes
MiniPiku 7a12801
fixed(Indentation): Restored proper spacing in code block
MiniPiku 3a45342
Changes:
MiniPiku 82c8635
Adapt Effective Dart design guidelines to Dart 3.0 class modifiers
MiniPiku e3db6c1
Changes made :
MiniPiku bc82de9
Conflicts resolved in 'src/content/language/patterns.md'
MiniPiku 41f58b3
Changes made :
MiniPiku 5855642
rephrasing '### DO use class modifiers to control if your class can b…
MiniPiku 13650d3
Changes made :
MiniPiku d0beca4
Changes made :
MiniPiku 53a01c9
Changes made :
MiniPiku 45f381f
changed 'base class B {}' --> 'interface class B{}'
MiniPiku e586ada
added missing period at the end
MiniPiku 75e7570
re-added the previously removed link in '_toc.md' file
MiniPiku 4dc729d
Added a post job step to ensure the emulator shuts down correctly, du…
MiniPiku 9f57c4a
Revert "Added a post job step to ensure the emulator shuts down corre…
MiniPiku eff55ab
modified the link
MiniPiku a57c770
Merge branch 'main' into guidelines-update-v1
MiniPiku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line shouldn't be removed AFAICT, can you make sure you re-ran the generator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep my bad i thought that this section was removed from the
design.md
file that's why i remove the link toolemme readd that
thanks for pointing it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done