Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page for pub bump #6196

Merged
merged 6 commits into from
Nov 11, 2024
Merged

New page for pub bump #6196

merged 6 commits into from
Nov 11, 2024

Conversation

MaryaBelanger
Copy link
Contributor

Fixes #6147

Not sure if I wrote line 9 correctly: $ dart pub bump <subcommand> [arguments]

Let me know if any other info would be helpful to include!

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Nov 6, 2024

Visit the preview URL for this PR (updated for commit 765695e):

https://dart-dev--pr6196-pub-bump-dp1ki9y4.web.app

src/content/tools/pub/cmd/pub-bump.md Outdated Show resolved Hide resolved
src/content/tools/pub/cmd/pub-bump.md Outdated Show resolved Hide resolved
src/content/tools/pub/cmd/pub-bump.md Outdated Show resolved Hide resolved
Comment on lines 33 to 36
### `-n, --dry-run`

Reports what would change for the version number, and shows the version diff,
without changing anything.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not actually implemented (perhaps it should be though...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dry-run isn't implemented? It comes up a few times in the PR though, is that just like making space for it in the future?

I'll remove it anyway for now to land the page, just curious!

Copy link
Contributor

@sigurdm sigurdm Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'm sorry - you are totally right.

I was looking at dart pub bump --help but should of course look at dart pub bump <subcommand> --help.

And it is indeed implemented (by me...).

Thanks for pointing this out!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Thanks for explaining, I put it back and specified it's for each subcommand

@MaryaBelanger MaryaBelanger merged commit a433611 into main Nov 11, 2024
10 checks passed
@MaryaBelanger MaryaBelanger deleted the pub-bump branch November 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for dart pub bump
3 participants