[cfe] Report cyclic dependency on declaration, not on type variable

This is a follow-up to https://dart-review.googlesource.com/c/sdk/+/339941/comment/356b962f_a73d18c8/ Change-Id: I193cee03bdfa766621d57dd4a47cc9f0da6c9c92 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340440 Reviewed-by: Erik Ernst <[email protected]> Reviewed-by: Johnni Winther <[email protected]> Commit-Queue: Chloe Stefantsova <[email protected]>
dart-lang · Dec 7, 2023 · d0aa049 · d0aa049
1 parent d3f2736
commit d0aa049
Show file tree

Hide file tree

Showing 26 changed files with 50 additions and 80 deletions.
diff --git a/pkg/front_end/lib/src/fasta/kernel/type_algorithms.dart b/pkg/front_end/lib/src/fasta/kernel/type_algorithms.dart
@@ -1259,7 +1259,7 @@ List<NonSimplicityIssue> convertRawTypeCyclesIntoIssues(
     if (cycle.length == 1) {
       // Loop.
       issues.add(new NonSimplicityIssue(
-          cycle.single.typeVariable!,
+          declaration,
           templateBoundIssueViaLoopNonSimplicity
               .withArguments(cycle.single.type.declaration!.name),
           null));

diff --git a/pkg/front_end/testcases/general/cyclic_typedef.dart.strong.expect b/pkg/front_end/testcases/general/cyclic_typedef.dart.strong.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/general/cyclic_typedef.dart:8:28: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/general/cyclic_typedef.dart:8:9: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'F2' here.
 // typedef F2 = void Function<X extends F2>();
-//                            ^
+//         ^^
 //
 // pkg/front_end/testcases/general/cyclic_typedef.dart:5:9: Error: The typedef 'F1' has a reference to itself.
 // typedef F1<X> = List<G1<X>>;

diff --git a/pkg/front_end/testcases/general/cyclic_typedef.dart.strong.transformed.expect b/pkg/front_end/testcases/general/cyclic_typedef.dart.strong.transformed.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/general/cyclic_typedef.dart:8:28: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/general/cyclic_typedef.dart:8:9: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'F2' here.
 // typedef F2 = void Function<X extends F2>();
-//                            ^
+//         ^^
 //
 // pkg/front_end/testcases/general/cyclic_typedef.dart:5:9: Error: The typedef 'F1' has a reference to itself.
 // typedef F1<X> = List<G1<X>>;

diff --git a/pkg/front_end/testcases/general/cyclic_typedef.dart.weak.expect b/pkg/front_end/testcases/general/cyclic_typedef.dart.weak.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/general/cyclic_typedef.dart:8:28: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/general/cyclic_typedef.dart:8:9: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'F2' here.
 // typedef F2 = void Function<X extends F2>();
-//                            ^
+//         ^^
 //
 // pkg/front_end/testcases/general/cyclic_typedef.dart:5:9: Error: The typedef 'F1' has a reference to itself.
 // typedef F1<X> = List<G1<X>>;

diff --git a/pkg/front_end/testcases/general/cyclic_typedef.dart.weak.modular.expect b/pkg/front_end/testcases/general/cyclic_typedef.dart.weak.modular.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/general/cyclic_typedef.dart:8:28: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/general/cyclic_typedef.dart:8:9: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'F2' here.
 // typedef F2 = void Function<X extends F2>();
-//                            ^
+//         ^^
 //
 // pkg/front_end/testcases/general/cyclic_typedef.dart:5:9: Error: The typedef 'F1' has a reference to itself.
 // typedef F1<X> = List<G1<X>>;

diff --git a/pkg/front_end/testcases/general/cyclic_typedef.dart.weak.outline.expect b/pkg/front_end/testcases/general/cyclic_typedef.dart.weak.outline.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/general/cyclic_typedef.dart:8:28: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/general/cyclic_typedef.dart:8:9: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'F2' here.
 // typedef F2 = void Function<X extends F2>();
-//                            ^
+//         ^^
 //
 // pkg/front_end/testcases/general/cyclic_typedef.dart:5:9: Error: The typedef 'F1' has a reference to itself.
 // typedef F1<X> = List<G1<X>>;

diff --git a/pkg/front_end/testcases/general/cyclic_typedef.dart.weak.transformed.expect b/pkg/front_end/testcases/general/cyclic_typedef.dart.weak.transformed.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/general/cyclic_typedef.dart:8:28: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/general/cyclic_typedef.dart:8:9: Error: Generic type 'F2' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'F2' here.
 // typedef F2 = void Function<X extends F2>();
-//                            ^
+//         ^^
 //
 // pkg/front_end/testcases/general/cyclic_typedef.dart:5:9: Error: The typedef 'F1' has a reference to itself.
 // typedef F1<X> = List<G1<X>>;

diff --git a/pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.strong.expect b/pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.strong.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C> = int;

diff --git a/...end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.strong.transformed.expect b/...end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.strong.transformed.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C> = int;

diff --git a/pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.weak.expect b/pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.weak.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C> = int;

diff --git a/...front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.weak.modular.expect b/...front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.weak.modular.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C> = int;

diff --git a/...front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.weak.outline.expect b/...front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.weak.outline.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C> = int;

diff --git a/...t_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.weak.transformed.expect b/...t_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.weak.transformed.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C> = int;

diff --git a/...nt_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.strong.expect b/...nt_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.strong.expect
@@ -2,15 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A, TypeY extends A> {}
-//         ^^^^^
-//
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:26: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
-// Try providing type arguments to 'A' here.
-// class A<TypeX extends A, TypeY extends A> {}
-//                          ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C, TypeY extends C> = int;

diff --git a/...ases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.strong.transformed.expect b/...ases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.strong.transformed.expect
@@ -2,15 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A, TypeY extends A> {}
-//         ^^^^^
-//
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:26: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
-// Try providing type arguments to 'A' here.
-// class A<TypeX extends A, TypeY extends A> {}
-//                          ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C, TypeY extends C> = int;

diff --git a/...ront_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.weak.expect b/...ront_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.weak.expect
@@ -2,15 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A, TypeY extends A> {}
-//         ^^^^^
-//
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:26: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
-// Try providing type arguments to 'A' here.
-// class A<TypeX extends A, TypeY extends A> {}
-//                          ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C, TypeY extends C> = int;

diff --git a/.../testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.weak.modular.expect b/.../testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.weak.modular.expect
@@ -2,15 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A, TypeY extends A> {}
-//         ^^^^^
-//
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:26: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
-// Try providing type arguments to 'A' here.
-// class A<TypeX extends A, TypeY extends A> {}
-//                          ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C, TypeY extends C> = int;

diff --git a/.../testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.weak.outline.expect b/.../testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.weak.outline.expect
@@ -2,15 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A, TypeY extends A> {}
-//         ^^^^^
-//
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:26: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
-// Try providing type arguments to 'A' here.
-// class A<TypeX extends A, TypeY extends A> {}
-//                          ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C, TypeY extends C> = int;

diff --git a/...tcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.weak.transformed.expect b/...tcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.weak.transformed.expect
@@ -2,15 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends A, TypeY extends A> {}
-//         ^^^^^
-//
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:8:26: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
-// Try providing type arguments to 'A' here.
-// class A<TypeX extends A, TypeY extends A> {}
-//                          ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart:10:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends C, TypeY extends C> = int;

diff --git a/...ront_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.strong.expect b/...ront_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.strong.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends Map<A, A>> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:11:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends Map<C, C>> = int;

diff --git a/...tcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.strong.transformed.expect b/...tcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.strong.transformed.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends Map<A, A>> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:11:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends Map<C, C>> = int;

diff --git a/pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.weak.expect b/pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.weak.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends Map<A, A>> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:11:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends Map<C, C>> = int;

diff --git a/...nd/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.weak.modular.expect b/...nd/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.weak.modular.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends Map<A, A>> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:11:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends Map<C, C>> = int;

diff --git a/...nd/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.weak.outline.expect b/...nd/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.weak.outline.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends Map<A, A>> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:11:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends Map<C, C>> = int;

diff --git a/...estcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.weak.transformed.expect b/...estcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.weak.transformed.expect
@@ -2,10 +2,10 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:9: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
+// pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:9:7: Error: Generic type 'A' can't be used without type arguments in the bounds of its own type variables.
 // Try providing type arguments to 'A' here.
 // class A<TypeX extends Map<A, A>> {}
-//         ^^^^^
+//       ^
 //
 // pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart:11:9: Error: The typedef 'C' has a reference to itself.
 // typedef C<TypeX extends Map<C, C>> = int;

diff --git a/tests/language/regress/regress34635_test.dart b/tests/language/regress/regress34635_test.dart
@@ -7,7 +7,7 @@ class A<X extends C> {}
 // [analyzer] COMPILE_TIME_ERROR.NOT_INSTANTIATED_BOUND
 
 class C<X extends C> {}
-//      ^
+//    ^
 // [cfe] Generic type 'C' can't be used without type arguments in the bounds of its own type variables.
 //                ^
 // [analyzer] COMPILE_TIME_ERROR.NOT_INSTANTIATED_BOUND