Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include bare pub --help command in help_test #4112

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Include bare pub --help command in help_test #4112

wants to merge 3 commits into from

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Jan 16, 2024

I noticed we had no golden for pub --help.

Trying to fix that.

@sigurdm sigurdm requested review from jonasfj and szakarias January 16, 2024 11:56
szakarias
szakarias approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szakarias
Copy link
Contributor

Shouldn't we just land this?

@sigurdm
Copy link
Contributor Author

sigurdm commented Mar 7, 2024

Yeah - sorry I was hesitating a bit with this.

I discovered that pub --help is already covered by the test/embedding/ tests. Maybe we should move all the help tests there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szakarias szakarias szakarias approved these changes

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sigurdm @szakarias @jonasfj