Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffigen] Fix decl_decl_collision_test.dart #1899

Merged
merged 6 commits into from
Jan 16, 2025
Merged

[ffigen] Fix decl_decl_collision_test.dart #1899

merged 6 commits into from
Jan 16, 2025

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Jan 15, 2025

There were 2 bugs here.

  • One issue was that since the transformer refactor, this test's bindings weren't being transformed, so none of the renaming was being applied. Just had to update the test to fix this.
  • The other issue is that the renamings weren't taking into account the imported libraries (eg import 'dart:ffi' as ffi; would conflict with bindings named ffi). There was an existing step that renamed user imported libraries, so I've just extended it to also rename built-in imports like ffi.

Fixes #1889

Copy link

github-actions bot commented Jan 15, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
objective_c Breaking 4.1.0 5.0.0-wip 5.0.0 ✔️
API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@liamappelbe liamappelbe changed the title WIP: [ffigen] Fix #1889 WIP: [ffigen] Fix decl_decl_collision_test.dart Jan 15, 2025
@coveralls
Copy link

coveralls commented Jan 16, 2025

Coverage Status

coverage: 91.459%. first build
when pulling ab72f83 on fix1889
into 817c76e on main.

@liamappelbe liamappelbe changed the title WIP: [ffigen] Fix decl_decl_collision_test.dart [ffigen] Fix decl_decl_collision_test.dart Jan 16, 2025
@liamappelbe liamappelbe marked this pull request as ready for review January 16, 2025 01:17
@liamappelbe liamappelbe merged commit 8882a55 into main Jan 16, 2025
22 checks passed
@liamappelbe liamappelbe deleted the fix1889 branch January 16, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ffigen] decl_decl_collision_test.dart is broken
3 participants