Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_cli] Fix system libraries and add documentation - fix test #1883

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

dcharkes
Copy link
Collaborator

I addressed the lint to have lower-case method names, but forgot that the native symbol in Windows is upper case.

Because the fix for using system/process/executable is not yet in Dart, this wasn't caught by the integration test on this repo running dart test because it's disabled until the fix rolls into dev.

log

00:55 �[32m+3�[0m: package:system_library dart test�[0m

00:00 +0: loading test\memory_test.dart
00:00 +0: test\memory_test.dart: executable
00:00 +0 -1: test\memory_test.dart: executable [E]
  Invalid argument(s): Couldn't resolve native function 'coTaskMemAlloc' in 'package:system_library/memory_executable.dart' : Failed to lookup symbol 'coTaskMemAlloc': The specified procedure could not be found.
   (error code: 127).
  
  dart:ffi                                       Native._ffi_resolver_function
  package:system_library/memory_executable.dart  coTaskMemAlloc
  test\memory_test.dart 16:34                    main.<fn>
  
00:00 +0 -1: test\memory_test.dart: process
00:00 +0 -2: test\memory_test.dart: process [E]
  Invalid argument(s): Couldn't resolve native function 'coTaskMemAlloc' in 'package:system_library/memory_process.dart' : Failed to lookup symbol 'coTaskMemAlloc': None of the loaded modules contained the requested symbol 'coTaskMemAlloc'..
  
  dart:ffi                                    Native._ffi_resolver_function
  package:system_library/memory_process.dart  coTaskMemAlloc
  test\memory_test.dart 28:31                 main.<fn>
  
00:00 +0 -2: test\memory_test.dart: system
00:00 +0 -3: test\memory_test.dart: system [E]
  Invalid argument(s): Couldn't resolve native function 'coTaskMemAlloc' in 'package:system_library/memory_system.dart' : Failed to lookup symbol 'coTaskMemAlloc': The specified procedure could not be found.
   (error code: 127).
  
  dart:ffi                                   Native._ffi_resolver_function
  package:system_library/memory_system.dart  coTaskMemAlloc
  test\memory_test.dart 40:30                main.<fn>
  
00:00 +0 -3: Some tests failed.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 87.72%. remained the same
when pulling c5273a8 on fix-test
into a7fb6ee on main.

@dcharkes dcharkes merged commit ba55784 into main Jan 13, 2025
32 checks passed
@dcharkes dcharkes deleted the fix-test branch January 13, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants