Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[objective_c] Add a bunch more categories to the bindings #1875

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Jan 9, 2025

Added all the NSExtendedFoo categories I could find.

Fixes #1818
Fixes #1873

Copy link

github-actions bot commented Jan 9, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
objective_c ObjCBlockBase
c._ObjCBlockImpl
_ObjCBlockDesc
_ObjCBlockRef
_ObjCObject
_Dart_FinalizableHandle
_ObjCProtocol
_ObjCSelector
_ObjCMethodDesc
_ObjCObjectRef
_NSZone

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Jan 9, 2025

Coverage Status

coverage: 87.434%. remained the same
when pulling fc00d05 on arraycat
into a650ccb on main.

@@ -1,3 +1,5 @@
## 17.0.0-wip

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comment like:

  • Uses package:objective_c 5.0

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@liamappelbe liamappelbe merged commit 87ef391 into main Jan 15, 2025
22 checks passed
@liamappelbe liamappelbe deleted the arraycat branch January 15, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSDate.timeIntervalSince1970 missing from generated code NSArray is missing some properties
3 participants