-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an error and adjust the terminology slightly about augmented redirecting constructors #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
changed the title
Adjust the terminology slightly about augmented redirecting constructors
Add an error and adjust the terminology slightly about augmented redirecting constructors
Nov 7, 2024
eernstg
commented
Nov 7, 2024
eernstg
commented
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented on two changes.
munificent
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying these weird corners!
jakemac53
approved these changes
Nov 14, 2024
Thanks! |
@sgrekhov, this should unblock a couple of PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an error for the case where a redirection (
this(...)
) is augmented by another redirection, and similarly for a redirecting factory.This follows the treatment of super-initializers, for which it is also an error to include one in an augmenting declaration if the augmented declaration already has an explicitly declared super-initializer.
Other than that, it clarifies the terminology of the augmentation feature specification slightly, such that we keep
this(...)
andthis.x = 42
clearly separated.'redirecting initializer' is changed to 'redirection' when talking about generative redirecting constructors. The term is derived from
<redirection>
, and the word redirection is used in other specification documents about this kind of term. This also helps avoiding the confusion aboutthis(...)
possibly being an initializer list element (likex = 42
orassert(b)
).I also added a few words of commentary right after the phrase 'factory redirection' because this phrase is new (the grammar rule actually doesn't have a separate name for the token sequence covered by this phrase). Finally, I deleted a TODO comment which is obsolete today (there are no special grammar rules about
augmented
).