-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the initial draft for inference-using-bounds #4140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but since I'm relatively inexperienced in writing specs, I'm going to tag in @eernstg as another reviewer
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
Cool to see the inline mermaid! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think the actual feature specification is the modification of 'inference.md', and the other document is all about background and motivation.
So I'm suggesting that feature-specification.md
is renamed (perhaps to design-document.md
).
With this rename in place, it's perfectly fine that the document doesn't specify the precise rules, and that it is completely example-driven.
I do suggest, though, that the formal update (that is, the new text in inference.md
) is mentioned up front in the design document, such that (1) readers will still know what the diff is without needing to track down the git update where inference.md
was updated, and (2) the design document is explicit about the precise thing that it's motivating and explaining. This would just be a short section.
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/feature-specification.md
Outdated
Show resolved
Hide resolved
That should improve the readability, since the new layout makes the nodes bigger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me just do LGTM, to make sure I am not blocking anything.
Github doesn't allow to comment that line, so I'm writing it here. File
Seems that it should be updated as well. |
…ted in the review comments
Thanks for spotting that! The informal section should be updated, tool. |
…set of type variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
accepted/future-releases/3009-inference-using-bounds/design-document.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/design-document.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/design-document.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/design-document.md
Outdated
Show resolved
Hide resolved
accepted/future-releases/3009-inference-using-bounds/design-document.md
Outdated
Show resolved
Hide resolved
Thanks for the review and the comments, everybody! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(accepted/future-releases/3009-inference-using-bounds/design-document.md )+
(resources/type-system/inference.md)
This PR adds the initial draft for the inference-using-bounds language feature specification.