Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it an error for the representation type of an extension type to be a bottom type #3393

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

eernstg
Copy link
Member

@eernstg eernstg commented Oct 11, 2023

In response to the discussion in #3383, this PR introduces a new compile-time error to the extension type feature specification: It is an error if the representation type is Never (or something with the same meaning).

Copy link
Member

@lrhn lrhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the phrasing means what it's supposed to mean.

@eernstg eernstg merged commit 3ecf3a7 into main Oct 12, 2023
3 checks passed
@eernstg eernstg deleted the spec_extension_type_not_Never_oct23 branch October 12, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants