Change the specified augmentation library structure for macros #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
added
the
static-metaprogramming
scheglov
reviewed
Sep 18, 2023
| When there are multiple augmentations of the same type declaration, they are | ||
| merged into a single `augment <type> {}` block. This is easier for end users to | ||
| understand. This includes multiple augmentations of the _same_ declaration, they | ||
| should appear as separate declarations within the same type augmentation. |
There was a problem hiding this comment.
I understand what the first statement means. If there are two macros that augment a class A by adding methods foo and bar, we get a single augmentation.
augment class A {
void foo() {}
void bar() {}
}I don't understand what the last statement means. Could you give an example?
There was a problem hiding this comment.
The second example means if you are augmenting foo multiple times, we put those in the same augment <type> {} declaration:
augment class A {
augment void foo() {}
augment void foo() {}
augment void foo() {}
augment void foo() {}
}There was a problem hiding this comment.
Note that the augmentation library proposal might need to be updated to explicitly allow this, I think it might be ambiguous today.
munificent
approved these changes
Sep 19, 2023
|
I pushed several examples, and removed the existing example which was not actually relevant any longer (it was based on the appending strategy). |
munificent
approved these changes
Sep 21, 2023
scheglov
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us to a more user friendly format (all augmentations for a single type grouped together), and removes the incorrect statements about source offset stability.
Closes #3350