Removed incorrect claim about promotability #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
approved these changes
Sep 12, 2023
He-Pin
reviewed
Sep 13, 2023
| @@ -274,6 +274,7 @@ leaves, and nothing else. | |||
| ```dart | |||
| extension type TinyJson(Object it) { | |||
| Iterable<num> get leaves sync* { | |||
| final it = this.it; // To get promotion. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have a hint in the extension type feature specification that the representation variable can be promoted just like a final local variable. This is not true (cf. dart-lang/sdk#53446 (comment)). This PR changes the feature specification such that it does not make that claim any more.
Correction: Promotion of the representation variable is sound, cf. dart-lang/sdk#53446 (comment). However, this PR still cleans up the text.
Another PR will follow when we have decided on the applicability of promotion to representation variables, cf. #3342.