Change noSuchMethod example to be correct with null safety #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 33a146f): https://dart-specification--pr2343-specify-nosuchmethod-lpvpn04v.web.app (expires Fri, 23 Dec 2022 12:59:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6941ecd630c4f067ff3d02708a45ae0f0a42b88a |
|
@lrhn, friendly ping? |
… correct in pre-nnbd code)
eernstg
force-pushed
the
specify_noSuchMethod_fix_jul22
branch
from
8b6079a to
33a146f
Compare
lrhn
approved these changes
Dec 16, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. #2052. This PR changes an example in the language specification section on
noSuchMethodsuch that it is correct with null safety (it is correct without null safety as well, so we can do it now, and it will simply be there when we land the null safety updates).