Minimal screenshot tool. #4074
Open
Minimal screenshot tool. #4074
+519
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Jul 7, 2025
| @@ -51,6 +57,8 @@ void main() { | |||
| // Set up the pub metadata for our test packages. | |||
| runPubGet(testPackageToolError.path); | |||
| runPubGet(_testSkyEnginePackage.path); | |||
|
|
|||
| if (isScreenshotDirSet) {} | |||
There was a problem hiding this comment.
Yes. We want to run screenshots only when the output directory is set, regular tests should run without if - at least for now.
There was a problem hiding this comment.
But the "then" branch is empty...
There was a problem hiding this comment.
Ah, my bad, mobile view of the code needs more attention.
No, this is not intentional, a leftover, will fix it once I'm with a computer.
sigurdm
reviewed
Jul 7, 2025
| @@ -27,7 +27,10 @@ dev_dependencies: | |||
| dart_style: ^3.0.0 | |||
| lints: ">=5.0.0 <7.0.0" | |||
| matcher: ^0.12.15 | |||
| puppeteer: ^3.18.0 | |||
There was a problem hiding this comment.
We might need to discuss if we want a non-dart-team dependency here (even if it is a dev-dependency)
cc @szakarias wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_browser.dartand thescreenshot_util.dartis a slightly adjusted copy fromdart-lang/pub-dev. I think in the long term we may want to extract it into a utility package that could be imported by both projects.pub-dev(or again, extract it into a shared package).