Formatting Dart code + enforcing it on CI. #4073
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I have no idea whether this is good/required for the template files with lots of changes, but for the rest of the files it seems somewhat important to make them consistent with other project workflows where the
dart format
is prerequisite of the approval.I've extended the tool to run
dart format .
after the tool generates the template files.I've also extended the CI tool to run it before the
dart analyzer
is run (in the same command block, for simplicity, and also because there is very little reason to run them separately).