Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place footer below main content #4014

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

parlough
Copy link
Member

@parlough parlough commented Mar 10, 2025

Update the site's layout implementation so that the main content can scroll with the entire viewport rather than having a separate scroll view. This allows the footer to be placed after the main content rather than fixed at the bottom and better aligns the site's layout with dart.dev and docs.flutter.dev.

  • Don't limit the body to a height of 100%, so that the main content can be scrolled as part of the primary/full viewport. This is what allows the footer to be after the content.
  • Make header sticky so they always remain visible at the top of the viewport.
  • Make sidebars sticky, but below the header, so that they remain visible when scrolling the main content.
  • Remove custom webkit scrollbar styles as they cause part of the header's chrome to go missing and are platform dependent.
    • Add color-scheme: <light or dark> to the theme styles so the browser provides properly themed scrollbars.
    • Removing these styles also resolves a TODO relating to the mobile version of the sidebars.

Resolves #4013

@parlough
Copy link
Member Author

I tested locally with Flutter, Dart, and the testing package. I recommend staging at least testing-package yourself to get a feel of the change:

dart run tool/task.dart serve testing-package

@parlough
Copy link
Member Author

I staged the flutter docs at: https://parlough-api-dart-dev.firebaseapp.com/doc/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dart api docs footer should have ability to be dismissed/closed
1 participant