Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up theme styling and improve accessibility of theme toggle #4005

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Clean up theme styling and improve accessibility of theme toggle #4005

merged 1 commit into from
Feb 20, 2025

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 19, 2025 •
edited
Loading

  • Utilize SCSS nesting in theme styles
  • Hide the IDs of internal icons of theme toggle from screen readers
  • Enable a focus style for theme toggle by switching to a button
  • Properly center theme toggle

Focused while in light mode:
Screenshot of toggle focused while in light mode

Focused while in dark mode:
Screenshot of toggle focused while in dark mode

Hovered while in dark mode:
Screenshot of toggle hovered while in dark mode

@srawlins
Copy link
Member

When you're ready, would you mind including some screenshots?

kevmoo
kevmoo reviewed Feb 19, 2025
View reviewed changes
@parlough parlough requested a review from srawlins February 19, 2025 23:50
srawlins
srawlins approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@srawlins srawlins merged commit 026aa2a into dart-lang:main Feb 20, 2025
9 checks passed
@parlough parlough deleted the feat/theme-button-a11y branch February 20, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo left review comments

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parlough @srawlins @kevmoo