-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icon and tooltip for reload. #3237
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
pkgs/dartpad_ui/lib/widgets.dart
Outdated
icon: const Icon(Icons.refresh, color: Colors.black, size: 20), | ||
icon: const Icon(Icons.flash_on, color: Colors.black, size: 20), | ||
tooltip: | ||
'Apply the changes with the hot reload mechanism: ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can be pretty terse here - users will generally be familiar with hot reload. The tooltip can help them identify that that's what this button does.
Perhaps 'Apply changes and hot reload.'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to update the tooltip text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another thread about tooltip text: #3237 (comment)
I do not have strong opinion here.
So, maybe you and Ryan chat directly with each other and I will take what you agreed on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ryan's (likely) unavailable at Cloud Next; I prefer short, clear tooltips. I think you can land your preference however - this is easy to come along later w/ a follow-up PR if we do decide we want different verbiage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer longer version, because DartPad is a place where many people start learning Flutter. So, I would not assume they know what is hot reload, and, if they do not, it is a great chance to educate them.
I need lgtm to land. :)
pkgs/dartpad_ui/lib/widgets.dart
Outdated
icon: const Icon(Icons.refresh, color: Colors.black, size: 20), | ||
icon: const Icon(Icons.flash_on, color: Colors.black, size: 20), | ||
tooltip: | ||
'Apply the changes with the hot reload mechanism: ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would change the tooltip to "Apply changes with Hot Reload, which updates widgets without losing the state of the app."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied
Added 'when possible' :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And replaced 'updates' with 're-renders the modified'
Make it more similar to what is in VSCode:

Before change:

After change: