Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon and tooltip for reload. #3237

Merged
merged 9 commits into from
Apr 9, 2025
Merged

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Apr 4, 2025

Make it more similar to what is in VSCode:
Screenshot 2025-04-04 at 11 07 42 AM

Before change:
Screenshot 2025-04-04 at 11 16 11 AM

After change:

Screenshot 2025-04-08 at 4 06 24 PM

@polina-c polina-c requested review from devoncarew and johnpryan April 4, 2025 18:07
Copy link

github-actions bot commented Apr 4, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

icon: const Icon(Icons.refresh, color: Colors.black, size: 20),
icon: const Icon(Icons.flash_on, color: Colors.black, size: 20),
tooltip:
'Apply the changes with the hot reload mechanism: '
Copy link
Member

@devoncarew devoncarew Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can be pretty terse here - users will generally be familiar with hot reload. The tooltip can help them identify that that's what this button does.

Perhaps 'Apply changes and hot reload.'?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to update the tooltip text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another thread about tooltip text: #3237 (comment)

I do not have strong opinion here.

So, maybe you and Ryan chat directly with each other and I will take what you agreed on?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ryan's (likely) unavailable at Cloud Next; I prefer short, clear tooltips. I think you can land your preference however - this is easy to come along later w/ a follow-up PR if we do decide we want different verbiage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer longer version, because DartPad is a place where many people start learning Flutter. So, I would not assume they know what is hot reload, and, if they do not, it is a great chance to educate them.

I need lgtm to land. :)

@polina-c polina-c requested a review from devoncarew April 8, 2025 23:07
icon: const Icon(Icons.refresh, color: Colors.black, size: 20),
icon: const Icon(Icons.flash_on, color: Colors.black, size: 20),
tooltip:
'Apply the changes with the hot reload mechanism: '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would change the tooltip to "Apply changes with Hot Reload, which updates widgets without losing the state of the app."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied

Added 'when possible' :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And replaced 'updates' with 're-renders the modified'

@polina-c polina-c requested a review from johnpryan April 9, 2025 18:03
@polina-c polina-c merged commit dbdc74b into dart-lang:main Apr 9, 2025
13 checks passed
@polina-c polina-c deleted the reload branch April 9, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants