Skip to content

#3057. Remove obsolete promotion_via_initialization_* tests #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One test needs to be discussed a bit more, though: TypeSystem/flow-analysis/promotion_via_assignment_A05_t01.dart.

@sgrekhov sgrekhov requested a review from eernstg April 29, 2025 12:06
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit e8ff373 into dart-lang:master Apr 29, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 2, 2025
2025-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.7.0 to 4.7.1 in the github-actions group (dart-lang/co19#3166)
2025-04-30 [email protected] dart-lang/co19#3057. Add type of interest tests. (dart-lang/co19#3161)
2025-04-30 [email protected] dart-lang/co19#3057. Update promotion via assignment tests (dart-lang/co19#3160)
2025-04-30 [email protected] dart-lang/co19#3057. Add promotion tests for `if` and `break` statements (dart-lang/co19#3156)
2025-04-29 [email protected] dart-lang/co19#3057. Add promotion tests for for-in loop (dart-lang/co19#3154)
2025-04-29 [email protected] Fixes dart-lang/co19#3151. Update constants expression tests. (dart-lang/co19#3157)
2025-04-29 [email protected] dart-lang/co19#3057. Remove obsolete `promotion_via_initialization_*` tests (dart-lang/co19#3163)
2025-04-29 [email protected] dart-lang/co19#3057. Add promotion tests for do loop and continue statement (dart-lang/co19#3155)
2025-04-29 [email protected] dart-lang/co19#3057. Fix typos in descriptions in `promotion_via_type_test_*` (dart-lang/co19#3164)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Icf2ea16079c6998c7c8eca502c7c6f08f816b445
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426060
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants